From 5ab2004a61e034a0191e111bbd9c02e41693e6bd Mon Sep 17 00:00:00 2001 From: David Scott Date: Mon, 8 Dec 2025 20:51:40 +0000 Subject: [PATCH 1/2] Fix bin-image workflow JSON parsing error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Update the crazy-max/.github reusable workflow to the latest version to fix a JSON parsing error that occurs when PR metadata contains control characters (like newlines in the PR body). The previous version (d9a10e2) used actions/github-script@v7 which had an issue where it embedded the GitHub event payload directly into a JavaScript template literal containing JSON. When JSON.parse() encountered unescaped control characters, it would fail with: SyntaxError: Bad control character in string literal in JSON at position... The newer version (387d336) uses actions/github-script@v8 which handles JSON serialization more properly, preventing these parsing errors. Fixes the build failure seen in PR #654. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 Signed-off-by: David Scott --- .github/workflows/bin-image.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bin-image.yml b/.github/workflows/bin-image.yml index d8d250caa..1c8aaa830 100644 --- a/.github/workflows/bin-image.yml +++ b/.github/workflows/bin-image.yml @@ -26,7 +26,7 @@ env: REPO_SLUG: moby/vpnkit-bin jobs: build: - uses: crazy-max/.github/.github/workflows/bake-distribute-mp.yml@d9a10e2737504a6e253f96e344cef684b0e00cb5 + uses: crazy-max/.github/.github/workflows/bake-distribute-mp.yml@387d336cac5f20cba622a6b9a866a80ea4c2c575 with: target: bin-image push: ${{ github.event_name != 'pull_request' && github.repository == 'moby/vpnkit' }} From 4c1f367cd3dc2e094fa12942c8d9d4df071f98a4 Mon Sep 17 00:00:00 2001 From: David Scott Date: Mon, 8 Dec 2025 20:54:54 +0000 Subject: [PATCH 2/2] Update CircleCI to use Xcode 14.3.1 with m4pro.medium resource class MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix CircleCI build failure caused by incompatible Xcode/resource class combination. The previous configuration used Xcode 14.0.0 which is not compatible with the new default m4pro.medium resource class. Changes: - Update Xcode from 14.0.0 to 14.3.1 (latest Xcode 14.x version) - Explicitly specify resource_class: m4pro.medium - This combination is supported per CircleCI's compatibility matrix Xcode 14.0.0 only supports older M1/M2 resource classes which are being deprecated in February 2026. Xcode 14.3.1 is compatible with the newer M4 Pro resource classes and will be supported long-term. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 Signed-off-by: David Scott --- .circleci/config.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index b65dfbd72..39a348e28 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -2,7 +2,8 @@ version: 2 jobs: build: macos: - xcode: "14.0.0" + xcode: "14.3.1" + resource_class: m4pro.medium environment: OPAMYES: "1" OPAMJOBS: "2"