refactor: improve error propagation and logging throughout execution chain

Enhanced error handling to ensure detailed error information from TapisJobService.getAppArgs flows through the entire execution chain to the API layer. Improved error logging in TapisExecutionService and subTasksService to provide comprehensive debugging information while ensuring users receive meaningful error responses.

Author: mosoriob

src/api/api-v1/services/subTasksService.ts

@@ -534,24 +534,35 @@ const subTasksService: SubTasksService = {
         let submissionResult: SubmissionResult = { submittedExecutions: [], failedExecutions: [] };
 
         if (executionCreation.executionToBeRun.length > 0) {
-            submissionResult = await executionService.submitExecutions(
-                executionCreation.executionToBeRun,
-                executionCreation.model,
-                executionCreation.threadRegion,
-                executionCreation.component,
-                subtask.id,
-                subtask.model_ensembles[w3id].id
-            );
-            if (submissionResult.failedExecutions.length > 0) {
-                console.warn(
-                    "Some executions failed to submit:",
-                    submissionResult.failedExecutions
+            try {
+                submissionResult = await executionService.submitExecutions(
+                    executionCreation.executionToBeRun,
+                    executionCreation.model,
+                    executionCreation.threadRegion,
+                    executionCreation.component,
+                    subtask.id,
+                    subtask.model_ensembles[w3id].id
                 );
+                if (submissionResult.failedExecutions.length > 0) {
+                    console.warn(
+                        "Some executions failed to submit:",
+                        submissionResult.failedExecutions
+                    );
+                    // Log detailed error information for each failed execution
+                    submissionResult.failedExecutions.forEach((failedExecution) => {
+                        console.error(`Execution ${failedExecution.execution.id} failed:`, failedExecution.error.message);
+                        console.error("Full error details:", failedExecution.error);
+                    });
+                }
+                console.log(
+                    "Successfully submitted executions:",
+                    submissionResult.submittedExecutions.length
+                );
+            } catch (error) {
+                console.error("Error during execution submission:", error instanceof Error ? error.message : String(error));
+                console.error("Full error details:", error);
+                throw new InternalServerError(`Failed to submit executions: ${error instanceof Error ? error.message : String(error)}`);
             }
-            console.log(
-                "Successfully submitted executions:",
-                submissionResult.submittedExecutions.length
-            );
         } else {
             console.log("No executions to run");
         }

src/classes/tapis/adapters/TapisExecutionService.ts

@@ -119,7 +119,8 @@ export class TapisExecutionService implements IExecutionService {
                 const jobId = await this.submitSingleExecution(app, seed, model, threadId);
                 submittedExecutions.push({ execution: seed.execution, jobId });
             } catch (error) {
-                console.error("Error submitting single execution", JSON.stringify(error));
+                console.error("Error submitting single execution:", error instanceof Error ? error.message : String(error));
+                console.error("Full error details:", error);
                 await this.handleSingleExecutionFailure(seed, error, threadModelId);
 
                 const serializableError: SerializableError = {
@@ -188,13 +189,20 @@ export class TapisExecutionService implements IExecutionService {
     ): void {
         if (failedExecutions.length > 0) {
             if (failedExecutions.length === this.seeds.length) {
-                const all_messages = failedExecutions.forEach((fe) => {
-                    console.error(`Execution ${fe.execution.id} failed: ${fe.error.message}`);
-                    return fe.error.message;
+                const errorMessages: string[] = [];
+                failedExecutions.forEach((fe) => {
+                    const errorMsg = `Execution ${fe.execution.id} failed: ${fe.error.message}`;
+                    console.error(errorMsg);
+                    console.error("Full error details for execution", fe.execution.id, ":", fe.error);
+                    errorMessages.push(fe.error.message);
                 });
-                throw new Error("All jobs failed to submit - " + all_messages);
+                throw new Error("All jobs failed to submit - " + errorMessages.join("; "));
             } else {
-                console.warn("Some jobs failed to submit:", failedExecutions);
+                console.warn("Some jobs failed to submit:");
+                failedExecutions.forEach((fe) => {
+                    console.warn(`Execution ${fe.execution.id} failed: ${fe.error.message}`);
+                    console.warn("Full error details for execution", fe.execution.id, ":", fe.error);
+                });
             }
         }
     }