Skip to content

Commit a5810db

Browse files
authored
.Net: Final test cleanup (#13328)
I think this completes the cleanup work I had planned on the tests.
1 parent b2cceb5 commit a5810db

File tree

71 files changed

+420
-463
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+420
-463
lines changed

dotnet/Directory.Packages.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@
155155
<PackageVersion Include="xretry" Version="1.9.0" />
156156
<PackageVersion Include="coverlet.collector" Version="6.0.4" />
157157
<PackageVersion Include="Docker.DotNet" Version="3.125.15" />
158+
<PackageVersion Include="Humanizer" Version="2.14.1" />
158159
<!-- Plugins -->
159160
<PackageVersion Include="DocumentFormat.OpenXml" Version="3.3.0" />
160161
<PackageVersion Include="Microsoft.Data.Sqlite" Version="9.0.10" />

dotnet/test/VectorData/AzureAISearch.ConformanceTests/AzureAISearch.ConformanceTests.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
<PackageReference Include="Microsoft.Extensions.Configuration.Json"/>
2424
<PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets"/>
2525
<PackageReference Include="System.Linq.AsyncEnumerable" />
26+
<PackageReference Include="Humanizer" />
2627
</ItemGroup>
2728

2829
<ItemGroup>

dotnet/test/VectorData/AzureAISearch.ConformanceTests/AzureAISearchCollectionManagementTests.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,4 @@
77
namespace AzureAISearch.ConformanceTests;
88

99
public class AzureAISearchCollectionManagementTests(AzureAISearchFixture fixture)
10-
: CollectionManagementTests<string>(fixture), IClassFixture<AzureAISearchFixture>
11-
{
12-
// Azure AI search only supports lowercase letters, digits or dashes.
13-
public override string CollectionName => "collection-tests";
14-
}
10+
: CollectionManagementTests<string>(fixture), IClassFixture<AzureAISearchFixture>;

dotnet/test/VectorData/AzureAISearch.ConformanceTests/AzureAISearchDistanceFunctionTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ public class AzureAISearchDistanceFunctionTests(AzureAISearchDistanceFunctionTes
1818

1919
public new class Fixture() : DistanceFunctionTests<string>.Fixture
2020
{
21-
public override string CollectionName => "distance-functions-" + AzureAISearchTestEnvironment.TestIndexPostfix;
22-
2321
public override TestStore TestStore => AzureAISearchTestStore.Instance;
2422

2523
// AzureAISearch does not return the expected standard mathematical result for each distance function

dotnet/test/VectorData/AzureAISearch.ConformanceTests/AzureAISearchEmbeddingGenerationTests.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@ public override Task SearchAsync_string_without_generator_throws()
2121
{
2222
public override TestStore TestStore => AzureAISearchTestStore.Instance;
2323

24-
// Azure AI search only supports lowercase letters, digits or dashes.
25-
public override string CollectionName => "embedding-gen-tests" + AzureAISearchTestEnvironment.TestIndexPostfix;
26-
2724
public override VectorStore CreateVectorStore(IEmbeddingGenerator? embeddingGenerator)
2825
=> AzureAISearchTestStore.Instance.GetVectorStore(new() { EmbeddingGenerator = embeddingGenerator });
2926

@@ -46,9 +43,6 @@ public override VectorStore CreateVectorStore(IEmbeddingGenerator? embeddingGene
4643
{
4744
public override TestStore TestStore => AzureAISearchTestStore.Instance;
4845

49-
// Azure AI search only supports lowercase letters, digits or dashes.
50-
public override string CollectionName => "search-only-embedding-gen-tests" + AzureAISearchTestEnvironment.TestIndexPostfix;
51-
5246
public override VectorStore CreateVectorStore(IEmbeddingGenerator? embeddingGenerator)
5347
=> AzureAISearchTestStore.Instance.GetVectorStore(new() { EmbeddingGenerator = embeddingGenerator });
5448

dotnet/test/VectorData/AzureAISearch.ConformanceTests/AzureAISearchFilterTests.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,5 @@ public override Task Contains_over_inline_int_array()
1717
public new class Fixture : FilterTests<string>.Fixture
1818
{
1919
public override TestStore TestStore => AzureAISearchTestStore.Instance;
20-
21-
// Azure AI search only supports lowercase letters, digits or dashes.
22-
public override string CollectionName => "filter-tests" + AzureAISearchTestEnvironment.TestIndexPostfix;
2320
}
2421
}
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
// Copyright (c) Microsoft. All rights reserved.
2+
3+
using AzureAISearch.ConformanceTests.Support;
4+
using VectorData.ConformanceTests;
5+
using VectorData.ConformanceTests.Support;
6+
using Xunit;
7+
8+
namespace AzureAISearch.ConformanceTests;
9+
10+
public class AzureAISearchHybridSearchTests(
11+
AzureAISearchHybridSearchTests.VectorAndStringFixture vectorAndStringFixture,
12+
AzureAISearchHybridSearchTests.MultiTextFixture multiTextFixture)
13+
: HybridSearchTests<string>(vectorAndStringFixture, multiTextFixture),
14+
IClassFixture<AzureAISearchHybridSearchTests.VectorAndStringFixture>,
15+
IClassFixture<AzureAISearchHybridSearchTests.MultiTextFixture>
16+
{
17+
public new class VectorAndStringFixture : HybridSearchTests<string>.VectorAndStringFixture
18+
{
19+
public override TestStore TestStore => AzureAISearchTestStore.Instance;
20+
}
21+
22+
public new class MultiTextFixture : HybridSearchTests<string>.MultiTextFixture
23+
{
24+
public override TestStore TestStore => AzureAISearchTestStore.Instance;
25+
}
26+
}

dotnet/test/VectorData/AzureAISearch.ConformanceTests/AzureAISearchIndexKindTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ public virtual Task Hnsw()
1818

1919
public new class Fixture() : IndexKindTests<string>.Fixture
2020
{
21-
public override string CollectionName => "index-kind-" + AzureAISearchTestEnvironment.TestIndexPostfix;
22-
2321
public override TestStore TestStore => AzureAISearchTestStore.Instance;
2422
}
2523
}

dotnet/test/VectorData/AzureAISearch.ConformanceTests/HybridSearch/AzureAISearchKeywordVectorizedHybridSearchTests.cs

Lines changed: 0 additions & 36 deletions
This file was deleted.

dotnet/test/VectorData/AzureAISearch.ConformanceTests/ModelTests/AzureAISearchBasicModelTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ public class AzureAISearchBasicModelTests(AzureAISearchBasicModelTests.Fixture f
1212
{
1313
public new class Fixture : BasicModelTests<string>.Fixture
1414
{
15-
public override string CollectionName => "basic-" + AzureAISearchTestEnvironment.TestIndexPostfix;
16-
1715
public override TestStore TestStore => AzureAISearchTestStore.Instance;
1816
}
1917
}

0 commit comments

Comments
 (0)