Remove driver_name and other review comments

Author: adityagesh

lisa/microsoft/testsuites/gpu/gpusuite.py

@@ -330,11 +330,9 @@ def _check_driver_installed(node: Node, log: Logger) -> None:
 
     lspci_gpucount = gpu.get_gpu_count_with_lspci()
 
-    # Get the ComputeSDK type for the supported GPU type
     compute_sdk = _get_supported_driver(node)
 
-    # Create GPU driver instance using virtual tool pattern
-    gpu_driver = node.tools.create(GpuDriver, compute_sdk=compute_sdk)
+    gpu_driver: GpuDriver = node.tools.get(GpuDriver, compute_sdk=compute_sdk)
     driver_gpucount = gpu_driver.get_gpu_count()
 
     assert_that(lspci_gpucount).described_as(
@@ -470,7 +468,7 @@ def __install_driver_using_sdk(node: Node, log: Logger, log_path: Path) -> None:
         log.debug(f"LisDriver is not installed. It might not be required. {e}")
 
     compute_sdk = _get_supported_driver(node)
-    _ = node.tools.create(GpuDriver, compute_sdk=compute_sdk)
+    _ = node.tools.get(GpuDriver, compute_sdk=compute_sdk)
 
     log.debug("GPU driver installed. Rebooting to load driver.")
     reboot_tool = node.tools[Reboot]

lisa/tools/gpu_drivers.py

@@ -2,7 +2,6 @@
 # Licensed under the MIT license.
 
 import re
-from abc import abstractmethod
 from enum import Enum
 from pathlib import PurePosixPath
 from typing import Any, List, Optional, Type
@@ -86,15 +85,13 @@ def create(
             f"Must be one of {list(ComputeSDK)}"
         )
 
-        gpu_driver_factory = Factory[GpuDriver](
-            GpuDriver  # type: ignore[type-abstract]
-        )
+        gpu_driver_factory = Factory[GpuDriver](GpuDriver)
 
-        driver_class = gpu_driver_factory.create_by_type_name(
+        driver = gpu_driver_factory.create_by_type_name(
             compute_sdk, node=node, **kwargs
         )
-        assert isinstance(driver_class, GpuDriver)
-        return driver_class
+        assert isinstance(driver, GpuDriver)
+        return driver
 
     @classmethod
     def type_name(cls) -> str:
@@ -118,17 +115,10 @@ def get_gpu_count(self) -> int:
         return smi_tool.get_gpu_count()
 
     @classmethod
-    @abstractmethod
     def smi(cls) -> Type[GpuSmi]:
         """Return the smi tool class for this driver"""
         raise NotImplementedError
 
-    @property
-    @abstractmethod
-    def driver_name(self) -> str:
-        """Return the human-readable driver name (e.g., 'NVIDIA GRID', 'NVIDIA CUDA')"""
-        raise NotImplementedError
-
     def get_version(self) -> str:
         """Get the currently installed driver version"""
         result = self.node.execute(f"{self.command} --version", shell=True, sudo=True)
@@ -149,23 +139,23 @@ def _install(self) -> bool:
         3. Reboot
         4. Verify installation
         """
-        self._log.info(f"Starting {self.driver_name} installation")
+        compute_sdk = self.__class__.type_name()
+        self._log.info(f"Starting {compute_sdk} driver installation")
 
         self._install_dependencies()
         self._install_driver()
-        self._log.info(f"{self.driver_name} installation completed successfully")
+        self._log.info(f"{compute_sdk} driver installation completed successfully")
 
         from lisa.tools.reboot import Reboot
 
         reboot_tool = self.node.tools[Reboot]
         reboot_tool.reboot()
 
         version = self.get_version()
-        self._log.info(f"Installed {self.driver_name} \n {version}")
+        self._log.info(f"Installed {compute_sdk} driver \n {version}")
 
         return True
 
-    @abstractmethod
     def _install_driver(self) -> None:
         """
         Install the actual GPU driver.
@@ -203,10 +193,6 @@ def smi(cls) -> Type[GpuSmi]:
 
         return NvidiaSmi
 
-    @property
-    def driver_name(self) -> str:
-        return "NVIDIA GRID"
-
     @property
     def command(self) -> str:
         return "nvidia-smi"
@@ -261,7 +247,8 @@ def _install_dependencies(self) -> None:
         if not dependencies:
             return
 
-        self._log.debug(f"Installing {self.driver_name} dependencies: {dependencies}")
+        compute_sdk = self.__class__.type_name()
+        self._log.debug(f"Installing {compute_sdk} dependencies: {dependencies}")
 
         assert isinstance(
             self.node.os, Posix
@@ -326,10 +313,6 @@ def smi(cls) -> Type[GpuSmi]:
 
         return NvidiaSmi
 
-    @property
-    def driver_name(self) -> str:
-        return "NVIDIA CUDA"
-
     @property
     def command(self) -> str:
         return "nvidia-smi"
@@ -393,7 +376,8 @@ def _install_dependencies(self) -> None:
         if not dependencies:
             return
 
-        self._log.debug(f"Installing {self.driver_name} dependencies: {dependencies}")
+        compute_sdk = self.__class__.type_name()
+        self._log.debug(f"Installing {compute_sdk} dependencies: {dependencies}")
 
         assert isinstance(
             self.node.os, Posix
@@ -580,10 +564,6 @@ def smi(cls) -> Type[GpuSmi]:
 
         return AmdSmi
 
-    @property
-    def driver_name(self) -> str:
-        return "AMD GPU (ROCm)"
-
     @property
     def command(self) -> str:
         return "amd-smi"
@@ -621,7 +601,8 @@ def _install_dependencies(self) -> None:
             "python3-wheel",
         ]
 
-        self._log.debug(f"Installing {self.driver_name} dependencies: {dependencies}")
+        compute_sdk = self.__class__.type_name()
+        self._log.debug(f"Installing {compute_sdk} dependencies: {dependencies}")
 
         assert isinstance(
             self.node.os, Posix