Skip to content

Commit 6416824

Browse files
committed
Only log Exceptions, not BaseException
1 parent 8334a74 commit 6416824

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

durabletask/internal/helpers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,12 @@ def new_sub_orchestration_failed_event(event_id: int, ex: Exception) -> pb.Histo
116116
)
117117

118118

119-
def new_failure_details(ex: BaseException, _visited: Optional[set[int]] = None) -> pb.TaskFailureDetails:
119+
def new_failure_details(ex: Exception, _visited: Optional[set[int]] = None) -> pb.TaskFailureDetails:
120120
if _visited is None:
121121
_visited = set()
122122
_visited.add(id(ex))
123123
inner: Optional[BaseException] = ex.__cause__ or ex.__context__
124-
if len(_visited) > 10 or (inner and id(inner) in _visited):
124+
if len(_visited) > 10 or (inner and id(inner) in _visited) or not isinstance(inner, Exception):
125125
inner = None
126126
return pb.TaskFailureDetails(
127127
errorType=type(ex).__name__,

0 commit comments

Comments
 (0)