Numeric directive names produces invalid html tags

[oskargotte]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected package

micromark-extension-directive@4.0.0

Steps to reproduce

I use this package to parse md into jsx in a React app. If I parse the text The time is 12:00, I get a tag name 00 which, when rendered to the dom, throws the error Failed to execute 'createElement' on 'Document': The tag name provided ('00') is not a valid name.

Actual behavior

Prior to version 4, the :00 would not be recognized as a custom directive but with the introduction of #24 it is.

Expected behavior

Is it an error to allow directive names to start with numbers or is it to be expected and to be handled by the user of this package by escaping colons as necessary?

Runtime

No response

Package manager

No response

Operating system

No response

Build and bundle tools

No response

[wooorm]

Hi!

when rendered to the dom

Someone is rendering to HTML, and it is not this project. That someone could also not care about HTML. And because of that, there is no weight given to what is and isn’t allowed in HTML (or, in this case, DOM/React).

---

For reference: #23 (comment).

So, it’s intentional that “invalid” HTML tag names are considered OK here.

[github-actions]

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

[oskargotte]

I see your point in this project not having to align with valid html tag names. It says in the syntax section that names should start with a letter though. Perhaps that should be updated?

[wooorm]

ah yes, i didn’t update that!