Files containing jsdoc syntax crash if js-ts-mode is enabled with combobulate

[sethidden]

Prerequisites

jsdoc and typescript grammars are installed e.g. using https://github.com/skyler544/treesit-auto/tree/php-ts-mode

combobulate is hooked on prog-mode-hook

Repro

1. Create a buffer with the following content:

/**
 * @example world
 */
const a ='hello'

2. Launch js-ts-mode

You will get the error:

cl--assertion-failed: Variable ‘combobulate-jsdoc-minor-mode’ does not exist in language ‘jsdoc’ with shorthand ‘minor-mode’

debug log

Debugger entered--Lisp error: (cl-assertion-failed ((boundp var) "Variable `%s' does not exist in language `%s' with shorthand `%s'"))
  cl--assertion-failed((boundp var) "Variable `%s' does not exist in language `%s' with shorthand `%s'" nil (combobulate-jsdoc-minor-mode jsdoc minor-mode))
  combobulate-get(minor-mode jsdoc t)
  combobulate-highlight-install(jsdoc)
  combobulate-setup()
  combobulate-javascript-minor-mode(1)
  combobulate-maybe-activate(nil nil)
  combobulate-mode()
  run-hooks(change-major-mode-after-body-hook prog-mode-hook js-base-mode-hook js-ts-mode-hook)
  apply(run-hooks change-major-mode-after-body-hook (prog-mode-hook js-base-mode-hook js-ts-mode-hook))
  run-mode-hooks(js-ts-mode-hook)
  js-ts-mode()
  funcall-interactively(js-ts-mode)
  command-execute(js-ts-mode record)
  execute-extended-command(nil "js-ts-mode" nil)
  funcall-interactively(execute-extended-command nil "js-ts-mode" nil)
  command-execute(execute-extended-command)

Environment

My config is:

  (use-package treesit-auto
    :ensure (:host github :repo "skyler544/treesit-auto" :branch "php-ts-mode")
    :config
    (setq treesit-auto-install t)
    (treesit-auto-add-to-auto-mode-alist 'all)
    (global-treesit-auto-mode))

  (use-package combobulate
    :ensure (:host github :repo "mickeynp/combobulate")
    :preface (setq combobulate-key-prefix "C-c o")
    :hook ((prog-mode yaml-ts-mode) . combobulate-mode))

GNU Emacs 31.0.50 (build 1, aarch64-apple-darwin24.3.0, NS appkit-2575.40 Version 15.3.1 (Build 24D70)) of 2025-02-27

[mickeynp]

Seems the primary language is mistakenly assumed to be jsdoc.

[mickeynp]

How exactly are these multiple tree-sitter grammars getting activated in one buffer? I presume you're using some sort of tool to do this.

[sethidden]

@mickeynp

How exactly are these multiple tree-sitter grammars getting activated in one buffer?

jsdoc seems to be activated by the default js-ts-mode included in Emacs

Please see:

• a comment mentioning jsdoc inside the js.el package
• https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/js.el#n4022

An even simpler config for repro would be:

  (use-package treesit
    :config
    (setq treesit-language-source-alist
     '((jsdoc "https://github.com/tree-sitter/tree-sitter-jsdoc")
       (typescript "https://github.com/tree-sitter/tree-sitter-typescript" "master" "typescript/src"))))

(use-package combobulate
    :ensure (:host github :repo "mickeynp/combobulate")
    :preface (setq combobulate-key-prefix "C-c o")
    :hook ((prog-mode yaml-ts-mode) . combobulate-mode))

(treesit-install-language-grammar for jsdoc and typescript then create buffer and enable mode like listed in original post

[mickeynp]

Ah thanks. I think I know what the problem is; will have to set aside some time to reproduce the issue.