QUESTION: are there evil keybindings yet?

[CrackedBeefcake]

pretty self-explanatory. I've looked on google and github but didnt find anything of the sorts.

is there a good reason that the combobulate keybindings havent yet been implemented in evil?
i might do it otherwise.

[mickeynp]

There are no evil key bindings.

[gs-101]

I think this type of stuff is done over at evil-collection.

[CrackedBeefcake]

the way i thought about doing this, was remapping hjkl etc. to their equivalences in combobulate.
which sounded pretty straight forward on the surface, and actually turns out to be fairly intuitive with a bit of practice.
I understand tho, that this is somewhat radical.

where i am now running into issues, is my lack of knowledge about combobulate. I am new to structural editing and just dont know what all off the things are that exist.
if you guys have any ideas or suggestions, feel free to chip in.

my plan now is to play around with this until i've groked it and it feels complete. then ill open a PR to evil-collection or publish it as a standalone minor mode.

These are the keys i am sure about: (not that many)

;;; combobulate-evil.el --- Vim-style navigation for Combobulate

(require 'combobulate)
(require 'evil)

(defgroup combobulate-evil nil
  "Vim-style navigation for Combobulate"
  :group 'combobulate)

(defcustom combobulate-evil-override-existing-bindings t
  "Whether to override existing Combobulate bindings."
  :type 'boolean
  :group 'combobulate-evil)

(defvar combobulate-evil-mode-map (make-sparse-keymap))

;;;###autoload
(define-minor-mode combobulate-evil-mode
  "Toggle Vim-style navigation for Combobulate."
  :lighter " CE"
  :keymap combobulate-evil-mode-map
  :group 'combobulate-evil
  (evil-normalize-keymaps))

;; Define the bindings for normal state
(evil-define-minor-mode-key 'normal 'combobulate-evil-mode
  ;; Linear navigation 
  "w" 'combobulate-navigate-logical-next
  "b" 'combobulate-navigate-logical-previous

  ;; Tree Navigation (hjkl)
  "h" 'combobulate-navigate-up
  "j" 'combobulate-navigate-next
  "k" 'combobulate-navigate-previous 
  "l" 'combobulate-navigate-down

  )

(add-to-list 'evil-overriding-maps
             (cons 'combobulate-evil-mode-map 'normal))

(provide 'combobulate-evil)

[martinbaillie]

Thanks for what you've done so far @LazerJesus. I would be keen to see something like this land in evil-collection.

[CrackedBeefcake]

as far as i see it, this could be done in two ways.
either as a primary way of navigation , or as a secondary.
either combobulate-evil takes center stage and structural becomes the primary mode of navigation and editing, or its used as a secondary / support.

primary would mean that wbe, hjkl, and other keys are rebound to combobulate functions. This would require re-learning a lot of muscle memory, but i'd expect the long term payoff to be huge.
secondary would mean that the combobulate functions are behind some leader-key.

I would love to get your inputs @martinbaillie @mickeynp @gs-101 and of course everyone elses.
maybe throw my little snippet above into a scratch buffer and run it to get a feel for the problem.

[gs-101]

I would love to get your inputs @martinbaillie @mickeynp @gs-101 and of course everyone elses. maybe throw my little snippet above into a scratch buffer and run it to get a feel for the problem.

Sure, I'll try it out.

Have you checked some (Neo)vim implementations of tree-sitter navigation for reference?

Here are some:

• textobjects
  • Evil counterpart
• treeclimber

[gs-101]

Just gave it a go. Took some time to get used to hjkl being replaced, but I enjoy it.

Will this be manually activated like it currently is, or hooked to the combobulate minor modes?

[CrackedBeefcake]

Will this be manually activated like it currently is, or hooked to the combobulate minor modes?

Exellent question @gs-101. Id assume this to be hooked into a minor mode, but whether this is on by default depends on the user and if combobulate-evil will be built as the primary mode of nav and editing, or as a secondary.
I think my goal is to make this into the primary way, but this is not trivial to get right and will take me a bit.
Glad you tried and enjoyed it!

Have you checked some (Neo)vim implementations of tree-sitter navigation for reference?

I was not aware of these and will test them. altho its been a good half decade or so since i touched neovim.

@mickeynp
when you navigate and edit code, do you use any functions that arent implemented in combobulate? if so, which and on what keys?

[mickeynp]

Not sure I follow, sorry!

What do you mean not implemented in combobulate? I use a huge range of key bindings and commands in Emacs.

[aisamu]

I dream everyday about a lispy-like combobulate mode