clean up old function

Author: Dan-Flores

src/torchcodec/_core/CudaDeviceInterface.cpp

@@ -379,14 +379,6 @@ std::string CudaDeviceInterface::getDetails() {
       (usingCPUFallback_ ? "CPU fallback." : "NVDEC.");
 }
 
-UniqueAVFrame CudaDeviceInterface::convertTensorToAVFrameForEncoding(
-    const torch::Tensor& tensor,
-    int frameIndex,
-    AVCodecContext* codecContext) {
-  return convertCUDATensorToAVFrameForEncoding(
-      tensor, frameIndex, codecContext);
-}
-
 // --------------------------------------------------------------------------
 // Below are methods exclusive to video encoding:
 // --------------------------------------------------------------------------
@@ -507,7 +499,7 @@ const Npp32f (*getConversionMatrix(AVCodecContext* codecContext))[4] {
 }
 } // namespace
 
-UniqueAVFrame CudaDeviceInterface::convertCUDATensorToAVFrameForEncoding(
+UniqueAVFrame CudaDeviceInterface::convertTensorToAVFrameForEncoding(
     const torch::Tensor& tensor,
     int frameIndex,
     AVCodecContext* codecContext) {

src/torchcodec/_core/CudaDeviceInterface.h

@@ -48,11 +48,6 @@ class CudaDeviceInterface : public DeviceInterface {
       int frameIndex,
       AVCodecContext* codecContext) override;
 
-  UniqueAVFrame convertCUDATensorToAVFrameForEncoding(
-      const torch::Tensor& tensor,
-      int frameIndex,
-      AVCodecContext* codecContext) override;
-
   void setupHardwareFrameContextForEncoding(
       AVCodecContext* codecContext) override;
 

src/torchcodec/_core/DeviceInterface.h

@@ -142,18 +142,11 @@ class DeviceInterface {
   // Pixel format used for encoding on CUDA devices
   static constexpr AVPixelFormat CUDA_ENCODING_PIXEL_FORMAT = AV_PIX_FMT_NV12;
 
-  virtual UniqueAVFrame convertTensorToAVFrameForEncoding(
-      [[maybe_unused]] const torch::Tensor& tensor,
-      [[maybe_unused]] int frameIndex,
-      [[maybe_unused]] AVCodecContext* codecContext) {
-    TORCH_CHECK(false);
-  }
-
   // Function used for video encoding, only implemented in CudaDeviceInterface.
   // It is here to isolate CUDA dependencies from CPU builds
   // TODO Video-Encoder: Reconsider using video encoding functions in device
   // interface
-  virtual UniqueAVFrame convertCUDATensorToAVFrameForEncoding(
+  virtual UniqueAVFrame convertTensorToAVFrameForEncoding(
       [[maybe_unused]] const torch::Tensor& tensor,
       [[maybe_unused]] int frameIndex,
       [[maybe_unused]] AVCodecContext* codecContext) {

src/torchcodec/_core/Encoder.cpp

@@ -743,8 +743,8 @@ void VideoEncoder::initializeEncoder(
     TORCH_CHECK(
         avFormatContext_->oformat != nullptr,
         "Output format is null, unable to find default codec.");
-    // Try to find hardware codec. This will return std::nullopt when device is
-    // CPU.
+    // Try to substitute the default codec with its hardware equivalent
+    // This will return std::nullopt when device is CPU.
     auto hwCodec = deviceInterface_->findCodec(
         avFormatContext_->oformat->video_codec, /*isDecoder=*/false);
     if (hwCodec.has_value()) {