Merge pull request #43 from meokullu/beep_fix_0002

v1.6.1 hotfix for Beep()

Author: meokullu

CHANGELOG.md

@@ -11,6 +11,11 @@
 #### Removed
 -->
 
+### [1.6.1]
+
+#### Fixed
+* [Hotfix]: Beep(Melody melody) was writing error on notes when duration of waiting as third element is zero.
+
 ### [1.6.0]
 
 #### Added

HelpConsole/HelpConsole.csproj

@@ -3,9 +3,9 @@
   <PropertyGroup>
     <TargetFrameworks>net6.0; net7.0; net461; netcoreapp3.1; netstandard2.0</TargetFrameworks>
     <ImplicitUsings>disable</ImplicitUsings>
-    <FileVersion>1.6.0</FileVersion>
-    <AssemblyVersion>1.6.0</AssemblyVersion>
-    <Version>1.6.0</Version>
+    <FileVersion>1.6.1</FileVersion>
+    <AssemblyVersion>1.6.1</AssemblyVersion>
+    <Version>1.6.1</Version>
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
     <GenerateDocumentationFile>True</GenerateDocumentationFile>
     <Title>Help Console</Title>
@@ -14,11 +14,12 @@
     <Copyright>Enes Okullu</Copyright>
     <PackageTags>console; console-application; console-app; helper</PackageTags>
     <PackageReleaseNotes>
-      v1.6.0
+      v1.6.1
       * Beep(Melody melody) was checking Melody elements with checking duration of beeping and duration of waiting as not being lower than zero. Now it is checking with equal or lower than zero as it should be.
       * SleepWithTitle(int duration) method added instead of Sleep(int duration). It writes sleeping duration into Console's title.
       * Sleep(int duration) now only waits instead of writing sleeping duration into screen.
       * Several features were not working due to default values of ConsoleOptions and ScreenColorOptions. Features like WriteLine() or StartingMethod() now can be used without calling `StartUp()`.
+      * [Hotfix]: Beep(Melody melody) was writing error on notes when duration of waiting as third element is zero.
       See changelog (https://github.com/meokullu/HelpConsole/blob/master/CHANGELOG.md)
     </PackageReleaseNotes>
     <RepositoryUrl>https://github.com/meokullu/HelpConsole</RepositoryUrl>

HelpConsole/src/Beep.cs

@@ -88,7 +88,7 @@ public static void Beep(Melody melody)
                 if (melody.Notes[i + 1] <= 0 || melody.Notes[i + 2] <= 0)
                 {
                     //
-                    WriteLine($"Error on notes. Notes at index: {i + 1}/{i + 2} {(melody.Notes[i + 1] < 0 ? "beeping duration should be greater than 0" : "")} {(melody.Notes[i + 2] < 0 ? "waiting duration should be greater than 0" : "")}");
+                    WriteLine($"Error on notes. Notes at index: {i + 1}/{i + 2} {(melody.Notes[i + 1] <= 0 ? "beeping duration should be greater than 0" : "")} {(melody.Notes[i + 2] <= 0 ? "waiting duration should be greater than 0" : "")}");
 
                     //
                     continue;

HelpConsole/src/Method.cs

@@ -13,7 +13,7 @@ public partial class HelpConsole
         /// <summary>
         /// Melody whose played when <see cref="StartingMethod(string)"/> is called.
         /// </summary>
-        private static Melody s_startMethodMelody = new Melody { Notes = new int[] { 725, 500, 0 } };
+        private static Melody s_startMethodMelody = new Melody { Notes = new int[] { 725, 300, 20 } };
 
         /// <summary>
         /// Sets melody that is played when <see cref="StartingMethod(string)"/> is called.
@@ -28,7 +28,7 @@ public static void SetStartMethodMelody(Melody melody)
         /// <summary>
         /// Melody whose played when <see cref="EndingMethod(string)"/> is called.
         /// </summary>
-        private static Melody s_endMethodMelody = new Melody { Notes = new int[] { 525, 500, 0 } };
+        private static Melody s_endMethodMelody = new Melody { Notes = new int[] { 525, 300, 20 } };
 
         /// <summary>
         /// Sets melody that is played when <see cref="EndingMethod(string)"/> is called.