precommit fixes

Author: mdtanker

pyproject.toml

@@ -198,8 +198,6 @@ extend-select = [
 ignore = [
   "PLR09",    # Too many <...>
   "PLR2004",  # Magic value used in comparison
-  "PD901",    # Bad variable name warning
-  "UP038",    # slows down code
 ]
 # Uncomment if using a _compat.typing backport
 # typing-modules = ["invert4geom._compat.typing"]

src/invert4geom/optimization.py

@@ -2612,7 +2612,7 @@ def __call__(self, trial: optuna.trial) -> float:
                     residual_constraint_score,
                     residual_amplitude_score,
                     true_reg_score,
-                    df,
+                    _df,
                 ) = cross_validation.regional_separation_score(
                     constraints_df=self.training_df,
                     testing_df=self.testing_df,

tests/test_inversion.py

@@ -777,7 +777,7 @@ def test_run_inversion():
         delta_l2_norm_tolerance=1.005,
     )
 
-    topo_results, grav_results, parameters, elapsed_time = results
+    topo_results, _grav_results, _parameters, _elapsed_time = results
 
     final_topography = topo_results.set_index(["northing", "easting"]).to_xarray().topo
     starting_topography = (

tests/test_utils.py

@@ -546,7 +546,7 @@ def test_extract_prism_data():
     """
     prism_layer = dummy_prism_layer()
     results = utils.extract_prism_data(prism_layer)
-    prisms_df, prisms_ds, spacing, topo_grid = results
+    _prisms_df, prisms_ds, spacing, topo_grid = results
     assert spacing == 200
     expected = np.array([[0.0, 0.0, 0.0], [-30.0, -30.0, -30.0], [30.0, 30.0, 30.0]])
     npt.assert_array_equal(expected, topo_grid)