Skip to content

Commit fb17ddb

Browse files
Merge pull request #44 from mcclatchy/PE-559-ad-close-button
PE-559 ad close button
2 parents 31f8fb4 + 50a5c2d commit fb17ddb

File tree

3 files changed

+25
-21
lines changed

3 files changed

+25
-21
lines changed
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
<!-- breaking news banner (for demo purposes) -->
2-
<div class="breaking-news-organism impact" id="primary-content">
2+
<div class="breaking-news-organism" id="primary-content">
33
<div class="breaking-news-macro">
4-
<div>
5-
<h3 class="h4"><span class="breaking-title">BREAKING NEWS: </span> <a href="https://alpha.montrealgazette.com/site-services/Newsletters/montreal-sports-newsletter/article54991.html"> Cricket is treated as the celebration in India </a></h3>
6-
</div>
7-
<div class="close-breaking-news">
8-
<div class="icon-wrap">
9-
<span class="glyphicon glyphicon-times close-breaking-news"></span>
10-
</div>
11-
</div>
4+
<h3 class="h4">
5+
<span class="breaking-title">BREAKING NEWS: </span>
6+
<a href="https://alpha.montrealgazette.com/site-services/Newsletters/montreal-sports-newsletter/article54991.html"> Cricket is treated as the celebration in India </a>
7+
</h3>
8+
<div class="close-breaking-news">
9+
<svg xmlns="http://www.w3.org/2000/svg" height="13.19px" viewBox="5.41 5.41 13.18 13.18" width="13.19px"><path d="M0 0h24v24H0V0z" fill="none"/><path d="M18.3 5.71c-.39-.39-1.02-.39-1.41 0L12 10.59 7.11 5.7c-.39-.39-1.02-.39-1.41 0-.39.39-.39 1.02 0 1.41L10.59 12 5.7 16.89c-.39.39-.39 1.02 0 1.41.39.39 1.02.39 1.41 0L12 13.41l4.89 4.89c.39.39 1.02.39 1.41 0 .39-.39.39-1.02 0-1.41L13.41 12l4.89-4.89c.38-.38.38-1.02 0-1.4z"/></svg>
10+
</div>
1211
</div>
1312
</div>

static/css/cards/breaking-news-banner.css

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@
55
*/
66

77
.breaking-news-organism {
8-
background-color: var(--red);
98
color: var(--white);
9+
background-color: var(--red);
10+
--text-color: var(--white);
11+
--fill-color: var(--text-color);
1012
max-width: 100%;
1113
height: 41px;
1214
}
@@ -24,27 +26,22 @@
2426
}
2527

2628
.breaking-news-macro h3 {
29+
font-weight: 400;
2730
margin: 0;
2831
}
2932

30-
.breaking-news-macro div.breaking-title {
31-
font-weight: bold;
33+
.breaking-title {
34+
font-weight: 700;
3235
}
3336

34-
.breaking-news-macro div.close-breaking-news {
37+
.close-breaking-news {
38+
flex: none;
39+
align-content: center;
3540
opacity: 1;
3641
transition: all .6s ease;
3742
min-width: 10px;
3843
}
3944

40-
.breaking-news-macro .icon-wrap {
41-
margin-bottom: 0;
42-
}
43-
44-
.breaking-news-macro .icon-wrap .close-breaking-news::before {
45-
content: url('data:image/svg+xml,%3Csvg xmlns="http://www.w3.org/2000/svg" width="8" height="9" viewBox="0 0 8 9" fill="none"%3E%3Cpath d="M7.59049 1.05497C7.81823 0.781777 7.78195 0.376006 7.50786 0.149016C7.23376 -0.0779743 6.82664 -0.0418166 6.5989 0.231375L3.87 3.49562L1.1411 0.231375C0.91336 -0.0418166 0.506242 -0.0779743 0.232143 0.149016C-0.0419554 0.376006 -0.0782332 0.781777 0.149511 1.05497L3.02956 4.5L0.149511 7.94503C-0.0782332 8.21822 -0.0419554 8.62399 0.232143 8.85098C0.506242 9.07797 0.91336 9.04182 1.1411 8.76862L3.87 5.50438L6.5989 8.76862C6.82664 9.04182 7.23376 9.07797 7.50786 8.85098C7.78195 8.62399 7.81823 8.21822 7.59049 7.94503L4.71044 4.5L7.59049 1.05497Z" fill="white"/%3E%3C/svg%3E');
46-
}
47-
4845
/*
4946
* Mobile CLS fix
5047
*/

static/css/cards/zones.css

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,4 +114,12 @@
114114
#zone-el-2.sticky-leaderboard {
115115
height: 66px;
116116
}
117+
}
118+
119+
#sticky_ad_close {
120+
position: absolute;
121+
top: 0;
122+
right: 25px;
123+
cursor: pointer;
124+
--fill-color: var(--black);
117125
}

0 commit comments

Comments
 (0)