Issue with local Windows paths and NRS data?

[xaviermouy]

Hello,

I was using pbp for analyzing Soundtrap data and it worked just fine. I am now looking at NRS data and am having issues with pbp-meta-gen. I am processing data from a local drive and use the same --uri argument format as what I was doing with Soundtraps but it is not able to from the .wav files to process.

Looking a bit closer at the code, I see that the way the paths are handled in NRSMetadataGenerator is different than in SoundTrapMetadataGenerator.

In SoundTrapMetadataGenerator I undertsand how the path in handles between lines 88-91.

if os.name == "nt":
     wav_path = Path(parsed_uri.netloc).joinpath(parsed_uri.path)
 else:
     wav_path = Path(parsed_uri.path)

However, in NRSMetadataGenerator it is handled with (line 77):

sound_path = Path(f"/{bucket}/{prefix}")

In my case (i.e. Windows, local folder), this creates a path that doesn't exist (i.e. it adds an unecessary '' before my actual folder path), which explains why the script cannot find any audio files.

Is there a reason why the paths are handled differently in NRSMetadataGenerator than in SoundTrapMetadataGenerator?

Thanks so much for any help you can provide!

[danellecline]

Hello @xaviermouy

Thanks for the question. My recollection was that support for Windows was added by @spacetimeengineer . Perhaps just added as needed for SoundTrapMetadataGenerator since he was working with that.

Does the NRSMetadataGenerator code work for you if you implement similar logic to the SoundTrapMetadataGenerator?

[ryjombari]

@xaviermouy @danellecline

For SoundCoop, I think we demonstrated processing NRS (haruphone) data in flac format, pulling straight from Google Cloud, in this notebook:
https://github.com/ioos/soundcoop/blob/main/1_process_to_HMD_pbp/NRS11/gen_HMD_NRS11_Haruphone.ipynb

[xaviermouy]

Thank you both for your very quick response (as usual).

@ryjombari I believe the issue is with the path when the data to be processed are local (and on windows?). I have not worked yet with Google Cloud paths

@danellecline, SoundTrapMetadataGenerator works well for me, so I suspect making NRSMetadataGenerator work similarly should be fine. Do you think it would be worth creating a separate unique function that handles the listing of the audio files that is called by both classes?

I also noticed that NRSMetadataGenerator can handle .wav and .flac files but that SoundTrapMetadataGenerator only handles .wav files. Would be nice to have both supported for all recorders. Maybe I shoud enter that as a separate issue/request as this is not as urgent

[danellecline]

SoundTrapMetadataGenerator works well for me, so I suspect making NRSMetadataGenerator work similarly should be fine. Do you think it would be worth creating a separate unique function that handles the listing of the audio files that is called by both classes?

Sure, some refactoring may make sense here.

Generally, we have added capability to metagen based on the uses cases and test sound data available to make sure the features are well tested before release, thanks to the good work @carueda did setting up the repo. If you could add your separate issue with test data, that would be helpful!