Replace string foo with Option<String> for titles

Author: matze

src/handlers/html/paste.rs

@@ -26,7 +26,7 @@ pub(crate) struct Paste {
     /// If the paste still in the database and can be fetched with another request.
     is_available: bool,
     html: String,
-    title: String,
+    title: Option<String>,
 }
 
 #[expect(clippy::too_many_arguments)]
@@ -63,7 +63,7 @@ pub async fn get(
             .zip(data.uid)
             .is_some_and(|(Uid(user_uid), owner_uid)| user_uid == owner_uid);
 
-        let title = data.title.clone().unwrap_or_default();
+        let title = data.title.clone();
 
         let html = if let Some(html) = cache.get(&key) {
             tracing::trace!(?key, "found cached item");
@@ -103,7 +103,7 @@ impl Paste {
         theme: Option<Theme>,
         can_delete: bool,
         is_available: bool,
-        title: String,
+        title: Option<String>,
         page: Page,
     ) -> Self {
         let html = html.into_inner();

src/handlers/html/qr.rs

@@ -26,7 +26,7 @@ pub async fn get(
         };
 
         let key: Key = id.parse()?;
-        let title = db.get_title(key.id).await?.unwrap_or_default();
+        let title = db.get_title(key.id).await?;
 
         // TODO: fix the bogus hardcoded can_delete and is_deleted fields.
         Ok(Qr {
@@ -53,7 +53,7 @@ pub(crate) struct Qr {
     can_delete: bool,
     is_available: bool,
     code: qrcodegen::QrCode,
-    title: String,
+    title: Option<String>,
 }
 
 impl Qr {

templates/paste.html

@@ -1,12 +1,12 @@
 {% extends "base.html" %}
 
 {% block title %}
-  {% if !title.is_empty() %}
+  {% if let Some(title) = title %}
     <div class="nav-title">{{ title }}</div>
   {% endif %}
 {% endblock %}
 
-{% block title_content %}{% if title.len() > 0 %}: {{ title }}{% endif %}{% endblock %}
+{% block title_content %}{% if let Some(title) = title %}: {{ title }}{% endif %}{% endblock %}
 
 {% block head %}
 <script defer src="{{ page.assets.paste_js.route() }}"></script>