Skip to content

Commit ce8c1ed

Browse files
authored
Merge pull request #141 from malloydata/remove-connection-details
Remove connections page
2 parents 2385ae2 + d687794 commit ce8c1ed

File tree

4 files changed

+5
-52
lines changed

4 files changed

+5
-52
lines changed

packages/app/src/components/ConnectionsPage.tsx

Lines changed: 0 additions & 25 deletions
This file was deleted.

packages/app/src/main.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { ThemeProvider } from "@mui/material/styles";
33
import * as React from "react";
44
import * as ReactDOM from "react-dom/client";
55
import { createBrowserRouter, RouterProvider } from "react-router-dom";
6-
import { ConnectionsPage } from "./components/ConnectionsPage";
76
import { HomePage } from "./components/HomePage";
87
import MainPage from "./components/MainPage";
98
import { ModelPage } from "./components/ModelPage";
@@ -38,17 +37,13 @@ const router = createBrowserRouter([
3837
path: ":projectName/:packageName",
3938
element: <PackagePage server={server} />,
4039
},
41-
{
42-
path: ":projectName/:packageName/scratchNotebook/:notebookPath",
43-
element: <ScratchNotebookPage server={server} />,
44-
},
4540
{
4641
path: ":projectName/:packageName/*",
4742
element: <ModelPage server={server} />,
4843
},
4944
{
50-
path: ":projectName/connections/:connectionName",
51-
element: <ConnectionsPage server={server} />,
45+
path: ":projectName/:packageName/scratchNotebook/:notebookPath",
46+
element: <ScratchNotebookPage server={server} />,
5247
},
5348
],
5449
},

packages/sdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@malloy-publisher/sdk",
33
"description": "Malloy Publisher SDK",
4-
"version": "0.0.24",
4+
"version": "0.0.25",
55
"type": "module",
66
"main": "dist/index.cjs.js",
77
"module": "dist/index.es.js",

packages/sdk/src/components/Package/Connections.tsx

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -23,28 +23,11 @@ interface ConnectionsProps {
2323
}
2424

2525
// TODO(jjs) - Move this UI to the ConnectionExplorer component
26-
function Connection({
27-
connectionProps,
28-
connection,
29-
}: {
30-
connectionProps: ConnectionsProps;
31-
connection: ApiConnection;
32-
}) {
33-
const { projectName } = connectionProps;
26+
function Connection({ connection }: { connection: ApiConnection }) {
3427
return (
3528
<TableRow key={connection.name}>
3629
<TableCell>
37-
<Typography
38-
variant="body2"
39-
sx={{ cursor: "pointer", color: "primary.main" }}
40-
onClick={() =>
41-
connectionProps.navigate(
42-
`/${projectName}/connections/${connection.name}/`,
43-
)
44-
}
45-
>
46-
{connection.name}
47-
</Typography>
30+
<Typography variant="body2">{connection.name}</Typography>
4831
</TableCell>
4932
<TableCell>
5033
<Typography variant="body2">{connection.type}</Typography>

0 commit comments

Comments
 (0)