Skip to content

Commit a4d0400

Browse files
committed
Run frontend tests separately from the build step
Previously, the backend tests would not run in CI if there was for example an eslint error. But now we can still build, and run the other tests, so we also get better coverage.
1 parent 3080f26 commit a4d0400

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

.github/workflows/makeradmin.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,17 @@ jobs:
3232
- name: Run tests
3333
run: make test
3434

35+
admin-frontend-tests:
36+
runs-on: ubuntu-latest
37+
steps:
38+
- uses: actions/checkout@v4
39+
- name: Install packages
40+
run: npm --prefix admin ci
41+
- name: Run tests
42+
run: npm --prefix admin run test
43+
- name: Lint
44+
run: npm --prefix admin run eslint
45+
3546
stripe-tests:
3647
runs-on: ubuntu-latest
3748
concurrency: stripe

admin/Dockerfile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@ RUN npm ci
1515
COPY ./src/ /work/src
1616
COPY ./jestSetup.js /work/
1717

18-
RUN npm run eslint
19-
20-
RUN npm run test
21-
2218
RUN npm run build
2319
RUN echo tsc --version
2420

0 commit comments

Comments
 (0)