`incus file mount` and `incus storage volume file mount` don’t perform enough checks

[bensmrs]

Is there an existing issue for this?

• There is no existing issue for this bug

Is this happening on an up to date version of Incus?

• This is happening on a supported version of Incus

Incus system details

HEAD

Instance details

No response

Instance log

No response

Current behavior

incus file mount and incus storage volume file mount don’t check whether instances, storage pools or storage volumes exist.

Expected behavior

An error if the instance, the storage pool or the storage volume don’t exist.

Steps to reproduce

> incus file mount xxxxxx
SSH SFTP listening on 127.0.0.1:54786
Login with username "QmfQk43Y" and password "e7sXMtza"
^C
> incus storage volume file mount xxxxxx yyyyyy
SSH SFTP listening on 127.0.0.1:54843
Login with username "ZMPIZdxS" and password "XU1rnoTz"

[J0nasDotDev]

Hi @stgraber 👋

I’d like to take this issue as my first contribution. Even as a user, I’m quite new to the project, but this issue looks very approachable.

As far as I understand, it simply involves adding checks just before calling sshSFTPServer in these two places:

• https://github.com/lxc/incus/blob/v6.21.0/cmd/incus/file.go#L1081-L1082
• https://github.com/lxc/incus/blob/v6.21.0/cmd/incus/storage_volume.go#L2782-L2785

Regarding tests, would you like me to add some negative integration tests for this?
If so, I will probably try to add them around some of these code blocks:

• https://github.com/lxc/incus/blob/v6.21.0/test/suites/basic.sh#L439-L456
• https://github.com/lxc/incus/blob/v6.21.0/test/suites/filemanip.sh#L145-L157
• https://github.com/lxc/incus/blob/v6.21.0/test/suites/storage_volume_filemanip.sh#L71-L73

[stgraber]

Yep, that sounds right as far as what needs updating.

For testing, the only place where we test incus file mount is in test/suites/filemanip.sh so it would make sense to include a test there, then add something similar to test/suites/storage_volume_filemanip.sh to cover the volume case.