add a test config for Chrome

Author: lonr

.eslintignore

@@ -7,3 +7,4 @@ coverage
 
 /*.js
 /*.ts
+

.github/workflows/ci.yml

@@ -2,9 +2,9 @@ name: Node.js CI
 
 on:
   push:
-    branches: [$default-branch]
+    branches: [main]
   pull_request:
-    branches: [$default-branch]
+    branches: [main]
 
 jobs:
   build:
@@ -25,6 +25,7 @@ jobs:
 
   test:
     runs-on: ubuntu-latest
+    timeout-minutes: 5
 
     strategy:
       matrix:
@@ -38,6 +39,8 @@ jobs:
           node-version: ${{ matrix.node-version }}
       - run: yarn
       - run: yarn test
+        env:
+          DISPLAY: :0
 
   lint:
     runs-on: ubuntu-latest

.github/workflows/publish.yml

@@ -8,18 +8,7 @@ on:
     types: [created]
 
 jobs:
-  test:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
-        with:
-          node-version: "14.x"
-      - run: yarn
-      - run: yarn test
-
   publish-npm:
-    needs: test
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -34,7 +23,6 @@ jobs:
           NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
 
   publish-gpr:
-    needs: test
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2

.vscode/launch.json

@@ -4,6 +4,21 @@
   // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
   "version": "0.2.0",
   "configurations": [
+    {
+      "name": "Debug Jest Tests",
+      "type": "node",
+      "request": "launch",
+      "runtimeArgs": [
+        "--inspect-brk=9229",
+        "${workspaceRoot}/node_modules/.bin/jest",
+        "--runInBand"
+      ],
+      "console": "integratedTerminal",
+      "internalConsoleOptions": "neverOpen",
+      "port": 9229,
+      "sourceMaps": true,
+      "disableOptimisticBPs": true
+    },
     {
       "type": "pwa-node",
       "request": "launch",
@@ -12,7 +27,7 @@
       "program": "${file}",
       // "program": "${workspaceFolder}${pathSeparator}dist${pathSeparator}${fileBasenameNoExtension}.js",
       // "args": ["--experimental-modules"],
-      "preLaunchTask": "tsc: build - tsconfig.debug.json",
+      "preLaunchTask": "tsc: build - tsconfig.json",
       "outFiles": ["${workspaceFolder}/dist/**/*.js"]
     }
   ]

README.md

@@ -2,7 +2,7 @@
 
 > **Unstable now, use it at your own risk**
 
-href is a lib for working with incomplete URLs (without a base) in the builtin [URL](https://developer.mozilla.org/en-US/docs/Web/API/URL)'s way
+href is a lib for working with incomplete (without a base) URLs in the builtin [URL](https://developer.mozilla.org/en-US/docs/Web/API/URL)'s way
 
 ## Usage
 
@@ -30,8 +30,8 @@ It behaviors like the builtin URL API:
   - When using `Href` with other incomplete URLs, only `href`, `pathname`, `search`, `searchParams`, `hash` will work
   - `new Href('path/to/file1?q=1').searchParams.set('q','2')`
   - `new Href('file2', 'path/to/file1').pathname === 'path/to/file2'`
-  - `new Href('file2', 'path/').pathname === 'path/to/file2'`
-  - `new Href('../../file2')'`
+  - `new Href('file2', 'path/').pathname === 'path/file2'`
+  - `new Href('../../file2')` keeps `../../`
 
 ## Credits
 

jest.config.ts

@@ -7,7 +7,7 @@ export default {
   projects: [
     {
       displayName: 'jsdom',
-      testEnvironment: './custom-test-environment.js',
+      testEnvironment: './jsdom-test-environment.js',
       clearMocks: true,
       globals: {
         'ts-jest': {
@@ -30,5 +30,11 @@ export default {
       preset: 'ts-jest',
       testPathIgnorePatterns: ['<rootDir>/dist/', '<rootDir>/node_modules/'],
     },
+    {
+      displayName: 'electron',
+      runner: '@jest-runner/electron',
+      testEnvironment: '@jest-runner/electron/environment',
+      transform: { '\\.ts$': 'ts-jest' },
+    },
   ],
 };

custom-test-environment.js jsdom-test-environment.jscustom-test-environment.js renamed to jsdom-test-environment.js

@@ -1,6 +1,6 @@
 {
   "name": "@lonr/href",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "href is a lib for working with incomplete URLs (without a base) in the builtin URL's way",
   "type": "commonjs",
   "main": "./dist/index.js",
@@ -42,10 +42,12 @@
     "path"
   ],
   "devDependencies": {
+    "@jest-runner/electron": "^3.0.0",
     "@rollup/plugin-commonjs": "^17.1.0",
     "@types/jest": "^26.0.20",
     "@typescript-eslint/eslint-plugin": "^4.14.2",
     "@typescript-eslint/parser": "^4.14.2",
+    "electron": "^11.2.3",
     "eslint": "^7.19.0",
     "eslint-config-prettier": "^7.2.0",
     "husky": "^5.0.9",
@@ -61,10 +63,7 @@
     "ts-jest": "^26.5.0",
     "ts-node": "^9.1.1",
     "tslib": "^2.1.0",
-    "typescript": "^4.1.3",
-    "webpack": "^5.20.0",
-    "webpack-cli": "^4.5.0",
-    "whatwg-url": "^8.4.0"
+    "typescript": "^4.1.3"
   },
   "dependencies": {}
 }

package.json

@@ -26,6 +26,10 @@ export default class Href {
     let parsedBase: HrefContext | null = null;
     // try to use `URL`
     try {
+      // prevent Chrome from parsing `new URL('#abc')`
+      if (baseStr === undefined && hrefStr.startsWith('#')) {
+        throw 'e';
+      }
       this._url = new URL(hrefStr, baseStr);
     } catch (error) {
       // with a base

src/href.ts

@@ -6,7 +6,7 @@
     /* Visit https://aka.ms/tsconfig.json to read more about this file */
     /* Basic Options */
     // "incremental": true,                   /* Enable incremental compilation */
-    "target": "ESNext" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. */,
+    "target": "ES2019" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. */,
     "module": "ESNext" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', 'es2020', or 'ESNext'. */,
     // "DOM" for TextEncoder, but Node has it too
     // "lib": ["ES2020", "DOM"],                             /* Specify library files to be included in the compilation. */