cargo-rail: fixed the crate name validation, dry-run, and other command/config issues

Author: loadingalias

src/commands/release.rs

@@ -17,11 +17,26 @@ pub fn run_release_plan(
   bump: String,
   json: bool,
 ) -> RailResult<()> {
-  println!("🔍 Planning release...\n");
+  if !json {
+    eprintln!("🔍 Planning release...\n");
+  }
 
   // Parse bump type
   let bump_type = bump.parse::<BumpType>()?;
 
+  // Validate crate names exist before planning
+  if let Some(ref names) = crate_names {
+    let workspace_members = ctx.graph.workspace_members();
+    for name in names {
+      if !workspace_members.contains(name) {
+        return Err(RailError::with_help(
+          format!("Crate '{}' not found in workspace", name),
+          format!("Available crates: {}", workspace_members.join(", ")),
+        ));
+      }
+    }
+  }
+
   // Get release config
   let config = ctx.config.as_ref().map(|c| &c.release);
   let release_config = config.ok_or_else(|| {
@@ -43,13 +58,13 @@ pub fn run_release_plan(
   } else {
     println!("{}", plan.format_summary());
 
-    println!("📝 This is a dry-run. To execute this release, run:");
+    eprintln!("\n📝 This is a dry-run. To execute this release, run:");
     if let Some(names) = crate_names {
       for name in names {
-        println!("   cargo rail release {} --execute", name);
+        eprintln!("   cargo rail release {}", name);
       }
     } else {
-      println!("   cargo rail release --all --execute");
+      eprintln!("   cargo rail release --all");
     }
   }
 
@@ -64,7 +79,6 @@ pub fn run_release_publish(
   crate_names: Option<Vec<String>>,
   all: bool,
   bump: String,
-  execute: bool,
   skip_publish: bool,
   skip_tag: bool,
 ) -> RailResult<()> {
@@ -98,25 +112,12 @@ pub fn run_release_publish(
   validator.validate(&target_crates, release_config.require_clean)?;
 
   // Build release plan
-  println!("🔍 Building release plan...\n");
+  eprintln!("🔍 Building release plan...\n");
   let planner = ReleasePlanner::new(ctx, release_config);
   let plan = planner.plan(targets, &bump_type)?;
 
-  // Display plan
-  println!("{}", plan.format_summary());
-
-  // Dry-run check
-  if !execute {
-    println!("\n🔍 DRY-RUN MODE - No changes will be made\n");
-    println!("To execute this release, add --execute flag:");
-    let target_str = if all {
-      "--all".to_string()
-    } else {
-      target_crates.join(" ")
-    };
-    println!("   cargo rail release {} --execute", target_str);
-    return Ok(());
-  }
+  // Display plan with skip flags reflected
+  println!("{}", plan.format_summary_with_flags(skip_publish, skip_tag));
 
   // Interactive confirmation (if terminal)
   if io::stdin().is_terminal() {

src/commands/split.rs

@@ -20,7 +20,9 @@ pub fn run_split(
   dry_run: bool,
   json: bool,
 ) -> RailResult<()> {
-  println!("📦 Loaded configuration");
+  if !json {
+    eprintln!("📦 Loaded configuration");
+  }
 
   // Build configurations using the centralized builder
   let builder = SplitSyncConfigBuilder::new(ctx)?
@@ -31,12 +33,12 @@ pub fn run_split(
   let all_local = builder.all_local();
   let config_count = builder.count();
 
-  if all_local && !dry_run {
-    println!("   Local testing mode\n");
+  if all_local && !dry_run && !json {
+    eprintln!("   Local testing mode\n");
   }
 
-  if all {
-    println!("   Splitting all {} configured crates", config_count);
+  if all && !json {
+    eprintln!("   Splitting all {} configured crates", config_count);
   }
 
   let configs = builder.build_split_configs()?;

src/commands/sync.rs

@@ -28,7 +28,9 @@ pub fn run_sync(
   // Parse conflict strategy
   let conflict_strategy = ConflictStrategy::from_str(&strategy_str)?;
 
-  println!("📦 Loaded configuration");
+  if !json {
+    eprintln!("📦 Loaded configuration");
+  }
 
   // Build configurations using the centralized builder
   let builder = SplitSyncConfigBuilder::new(ctx)?
@@ -40,8 +42,8 @@ pub fn run_sync(
   let all_local = builder.all_local();
   let config_count = builder.count();
 
-  if all_local && !dry_run {
-    println!("   Local testing mode\n");
+  if all_local && !dry_run && !json {
+    eprintln!("   Local testing mode\n");
   }
 
   // Determine sync direction
@@ -53,21 +55,27 @@ pub fn run_sync(
       ));
     }
     (true, false) => {
-      println!("   Direction: remote → monorepo");
+      if !json {
+        eprintln!("   Direction: remote → monorepo");
+      }
       SyncDirection::RemoteToMono
     }
     (false, true) => {
-      println!("   Direction: monorepo → remote");
+      if !json {
+        eprintln!("   Direction: monorepo → remote");
+      }
       SyncDirection::MonoToRemote
     }
     (false, false) => {
-      println!("   Direction: bidirectional");
+      if !json {
+        eprintln!("   Direction: bidirectional");
+      }
       SyncDirection::Both
     }
   };
 
-  if all {
-    println!("   Syncing all {} configured crates", config_count);
+  if all && !json {
+    eprintln!("   Syncing all {} configured crates", config_count);
   }
 
   let configs = builder.build_sync_configs()?;

src/main.rs

@@ -112,7 +112,7 @@ enum Commands {
   /// Split a crate from monorepo to separate repo with history
   ///
   /// Usage:
-  ///   cargo rail split init <crate>     - Initialize split config for crate(s)
+  ///   cargo rail split init             - Initialize split config for all workspace crates
   ///   cargo rail split <crate>          - Execute split for a crate
   ///   cargo rail split --all            - Execute split for all configured crates
   ///   cargo rail split --dry-run        - Preview split operations
@@ -425,7 +425,7 @@ fn main() {
           commands::run_release_plan(&ctx, names, bump, json)
         } else {
           // Execute mode: perform the release
-          commands::run_release_publish(&ctx, names, all, bump, true, skip_publish, skip_tag)
+          commands::run_release_publish(&ctx, names, all, bump, skip_publish, skip_tag)
         }
       }
     }

src/release/planner.rs

@@ -184,7 +184,11 @@ impl<'a> ReleasePlanner<'a> {
 
 impl ReleasePlan {
   /// Format summary for display
-  pub fn format_summary(&self) -> String {
+  ///
+  /// # Arguments
+  /// * `skip_publish` - If true, show publishing as skipped for all crates
+  /// * `skip_tag` - If true, show tagging as skipped for all crates
+  pub fn format_summary_with_flags(&self, skip_publish: bool, skip_tag: bool) -> String {
     let mut output = String::new();
 
     output.push_str("📦 Release Plan\n\n");
@@ -195,23 +199,49 @@ impl ReleasePlan {
         "   Version: {} → {}\n",
         crate_plan.current_version, crate_plan.new_version
       ));
-      output.push_str(&format!("   Tag: {}\n", crate_plan.tag_name));
-      output.push_str(&format!(
-        "   Publish: {}\n",
-        if crate_plan.publish { "✓" } else { "✗ (skipped)" }
-      ));
+
+      // Show tag status
+      let tag_status = if skip_tag {
+        "✗ (--skip-tag)"
+      } else {
+        &crate_plan.tag_name
+      };
+      output.push_str(&format!("   Tag: {}\n", tag_status));
+
+      // Show publish status
+      let publish_status = if skip_publish {
+        "✗ (--skip-publish)".to_string()
+      } else if crate_plan.publish {
+        "✓".to_string()
+      } else {
+        "✗ (publish = false)".to_string()
+      };
+      output.push_str(&format!("   Publish: {}\n", publish_status));
 
       if !crate_plan.affected_dependents.is_empty() {
         output.push_str(&format!("   Affects: {}\n", crate_plan.affected_dependents.join(", ")));
       }
       output.push('\n');
     }
 
+    // Adjust summary counts based on flags
+    let effective_publish_count = if skip_publish {
+      0
+    } else {
+      self.summary.crates_to_publish
+    };
+    let effective_tag_count = if skip_tag { 0 } else { self.summary.crates_to_tag };
+
     output.push_str(&format!(
       "Summary: {} crate(s), {} to publish, {} tag(s)\n",
-      self.summary.total_crates, self.summary.crates_to_publish, self.summary.crates_to_tag
+      self.summary.total_crates, effective_publish_count, effective_tag_count
     ));
 
     output
   }
+
+  /// Format summary for display (default: no skip flags)
+  pub fn format_summary(&self) -> String {
+    self.format_summary_with_flags(false, false)
+  }
 }