fix(vcomlink, zedkube): close response body ASAP

When doing HTTP requests in loops it's a good practice to close the
response body explicitly after reading it, instead of deferring it
until the surrounding function returns. This helps to free up resources
sooner and avoid potential resource leaks, especially in bigger loops.

Signed-off-by: Paul Gaiduk <[email protected]>
(cherry picked from commit 4d88c7a)

Author: europaul

pkg/pillar/cmd/vcomlink/vcomlink_test.go

@@ -306,13 +306,13 @@ func TestValidGetEkCert(t *testing.T) {
 		if err != nil {
 			t.Fatalf("failed to download issuing CA cert: %v", err)
 		}
-		defer resp.Body.Close()
 
 		if resp.StatusCode != http.StatusOK {
 			t.Fatalf("failed to download issuing CA cert, status code: %d", resp.StatusCode)
 		}
 
 		caCertData, err := io.ReadAll(resp.Body)
+		resp.Body.Close()
 		if err != nil {
 			t.Fatalf("failed to read issuing CA cert response body: %v", err)
 		}

pkg/pillar/cmd/zedkube/clusterstatus.go

@@ -412,14 +412,14 @@ func (z *zedkube) clusterAppIDHandler(w http.ResponseWriter, r *http.Request) {
 				}
 				continue
 			}
-			defer resp.Body.Close()
 
 			if resp.StatusCode != http.StatusOK {
 				log.Errorf("clusterAppIDHandler: received non-OK status %d from %s", resp.StatusCode, host)
 				continue
 			}
 
 			remoteAppInfoJSON, err := ioutil.ReadAll(resp.Body)
+			resp.Body.Close()
 			if err != nil {
 				log.Errorf("clusterAppIDHandler: error reading response from %s: %v", host, err)
 				continue