Skip to content

Commit 64aded6

Browse files
Merge branch 'fixExternalRepsField-826' into 'main'
Corrige problema com validação da submissão See merge request softwares-pkp/plugins_ojs/dataverse!207
2 parents 07aaa02 + 6b3aeb5 commit 64aded6

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

.gitlab-ci.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,9 @@ include:
77
file:
88
- 'templates/groups/pkp_plugin.yml'
99
- 'templates/groups/ojs/unit_tests.yml'
10-
- 'templates/groups/ojs/cypress_tests.yml'
10+
- 'templates/groups/ojs/cypress_tests.yml'
11+
12+
# Desabilita os jobs de testes de aceitação da aplicação, por enquanto
13+
ojs_integration_tests:
14+
rules:
15+
- when: never

classes/dispatchers/DataStatementDispatcher.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ public function validateSubmissionFields($hookName, $params)
216216
}
217217
}
218218

219-
if (in_array(DataStatementService::DATA_STATEMENT_TYPE_REPO_AVAILABLE, $dataStatementTypes)
219+
if (in_array(DataStatementService::DATA_STATEMENT_TYPE_PUBLICLY_UNAVAILABLE, $dataStatementTypes)
220220
&& !$dataStatementReason
221221
) {
222222
$errors['dataStatementReason'] = [__('plugins.generic.dataverse.dataStatement.publiclyUnavailable.reason.required')];

cypress/tests/Test1_submissionWizard.cy.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,12 @@ describe('Dataverse Plugin - Submission wizard features', function () {
4343

4444
it('Begins submission. Checks for data statement fields', function () {
4545
cy.login('eostrom', null, 'publicknowledge');
46-
46+
4747
cy.get('div#myQueue a:contains("New Submission")').click();
4848
beginSubmission(submissionData);
4949

50+
cy.intercept("POST", /submissions\/\d+\/submit/).as('submissionValidation');
51+
5052
cy.setTinyMceContent('titleAbstract-abstract-control-en', submissionData.abstract);
5153
submissionData.keywords.forEach(keyword => {
5254
cy.get('#titleAbstract-keywords-control-en').type(keyword, {delay: 0});
@@ -62,6 +64,11 @@ describe('Dataverse Plugin - Submission wizard features', function () {
6264
cy.contains('Insert the URLs to the data');
6365
cy.get('#dataStatement-dataStatementUrls-control').should('be.visible');
6466
advanceNSteps(4);
67+
cy.wait('@submissionValidation').then((interception) => {
68+
assert.equal(interception.response.statusCode, 400);
69+
assert.property(interception.response.body, 'dataStatementUrls');
70+
assert.notProperty(interception.response.body, 'dataStatementReason');
71+
});
6572
cy.contains('h3', 'Data statement');
6673
cy.contains('It is required to inform the URLs to the data in repositories');
6774

version.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
<version>
1414
<application>dataverse</application>
1515
<type>plugins.generic</type>
16-
<release>3.3.3.0</release>
17-
<date>2025-08-15</date>
16+
<release>3.3.3.1</release>
17+
<date>2025-09-11</date>
1818
<lazy-load>1</lazy-load>
1919
<class>DataversePlugin</class>
2020
</version>

0 commit comments

Comments
 (0)