@@ -113,10 +113,7 @@ impl HyperTransport {
113113 /// For HTTPS support or timeout configuration, use [`HyperTransport::builder()`].
114114 pub fn new ( ) -> Self {
115115 let connector = hyper_util:: client:: legacy:: connect:: HttpConnector :: new ( ) ;
116- // TODO(@@@): What are the default timeouts here?
117116 let timeout_connector = TimeoutConnector :: new ( connector) ;
118- // TODO(@@@): We should check if this is something we want to support. Instantiating a new
119- // tokio executor might be problematic. I'm not sure
120117 let client = HyperClient :: builder ( TokioExecutor :: new ( ) ) . build ( timeout_connector) ;
121118
122119 Self { client }
@@ -159,7 +156,6 @@ impl HyperTransport {
159156 . build ( ) ;
160157
161158 let timeout_connector = TimeoutConnector :: new ( connector) ;
162- // TODO(@@@): Also have to consider the tokio executor here
163159 let client = HyperClient :: builder ( TokioExecutor :: new ( ) ) . build ( timeout_connector) ;
164160
165161 HyperTransport { client }
@@ -296,13 +292,11 @@ impl HyperTransportBuilder {
296292 C :: Future : Send + ' static ,
297293 C :: Error : Into < Box < dyn std:: error:: Error + Send + Sync > > ,
298294 {
299- // QUESTION(@@@): Is this a method we still want to support?
300295 let mut timeout_connector = TimeoutConnector :: new ( connector) ;
301296 timeout_connector. set_connect_timeout ( self . connect_timeout ) ;
302297 timeout_connector. set_read_timeout ( self . read_timeout ) ;
303298 timeout_connector. set_write_timeout ( self . write_timeout ) ;
304299
305- // TODO(@@@): There is that pesky TokioExecutor again
306300 let client = HyperClient :: builder ( TokioExecutor :: new ( ) ) . build ( timeout_connector) ;
307301
308302 HyperTransport { client }
@@ -380,8 +374,6 @@ fn body_to_stream(
380374 if let Ok ( data) = frame. into_data ( ) {
381375 Some ( ( Ok ( data) , body) )
382376 } else {
383- // QUESTION(@@@): Is this going to be problematic? Is returning an error here
384- // necessary?
385377 // Skip non-data frames (trailers, etc.)
386378 Some ( (
387379 Err ( TransportError :: new ( std:: io:: Error :: other ( "non-data frame" ) ) ) ,
0 commit comments