wip

Author: tanderson-ld

packages/shared/common/src/internal/fdv2/payloadReader.ts

@@ -74,7 +74,7 @@ export class PayloadReader {
           );
         }
       } else {
-        this._errorHandler?.(DataSourceErrorKind.Unknown, 'Unexpected payload from event stream');
+        this._errorHandler?.(DataSourceErrorKind.Unknown, 'Unexpected message from event stream');
       }
     });
   }

packages/shared/sdk-server/src/data_sources/StreamingProcessorFDv2.ts

@@ -96,7 +96,6 @@ export default class StreamingProcessorFDv2 implements subsystem.LDStreamProcess
   start() {
     this._logConnectionStarted();
 
-    // TLS is handled by the platform implementation.
     const eventSource = this._requests.createEventSource(this._streamUri, {
       headers: this._headers,
       errorFilter: (error: HttpErrorResponse) => this._retryAndHandleError(error),

packages/shared/sdk-server/src/data_sources/createStreamListenersFDv2.ts

@@ -7,7 +7,6 @@ import {
   LDKeyedFeatureStoreItem,
 } from '../api/subsystems';
 
-// TODO: discuss if there is a better setup for this
 const namespaceForKind = (kind: string) => {
   switch (kind) {
     case 'feature':
@@ -30,6 +29,7 @@ export const createPayloadListener =
     // DataSourceUpdates will support update(...) taking in the list of updates.
     if (payload.basis) {
       // convert basis to init param structure
+      // TODO: remove conversion as part of FDv2 Persistence work
       const converted: LDFeatureStoreDataStorage = {};
       payload.updates.forEach((it: internal.Update) => {
         const namespace = namespaceForKind(it.kind);
@@ -55,9 +55,8 @@ export const createPayloadListener =
       logger?.debug('Initializing all data');
       dataSourceUpdates.init(converted, basisReceived);
     } else {
-      // TODO: is topo sort required here?
-
       // convert data to upsert param
+      // TODO: remove conversion as part of FDv2 Persistence work
       payload.updates.forEach((it: internal.Update) => {
         const converted: LDKeyedFeatureStoreItem = {
           key: it.key,