some fixes

Author: jackye1995

.github/workflows/create-major-minor-rc.yml

@@ -17,6 +17,7 @@ jobs:
       rc_version: ${{ steps.create_rc.outputs.RC_VERSION }}
       release_branch: ${{ steps.create_rc.outputs.RELEASE_BRANCH }}
       main_version: ${{ steps.create_rc.outputs.MAIN_VERSION }}
+      release_root_tag: ${{ steps.create_rc.outputs.RELEASE_ROOT_TAG }}
     steps:
     - name: Output Inputs
       run: echo "${{ toJSON(github.event.inputs) }}"
@@ -104,9 +105,10 @@ jobs:
         - **Rust**: Use git tag reference in Cargo.toml
 
         ### Voting Instructions
-        Please test the RC artifacts and vote:
-        - 👍 (:+1:) to approve
-        - 👎 (:-1:) if issues found (please comment with details)
+        Please test the RC artifacts and vote by commenting:
+        - **+1** to approve
+        - **0** to abstain or neutral
+        - **-1** if issues found (please include details)
 
         ### Next Steps
         - If approved: Promote to stable using \`promote-to-stable\` workflow

.github/workflows/create-rc.yml

@@ -98,9 +98,10 @@ A new release candidate has been created and is ready for voting.
 
 ## Voting
 
-Please test the RC and vote using reactions:
-- 👍 (:+1:) to approve
-- 👎 (:-1:) if issues found (please comment with details)
+Please test the RC and vote by commenting:
+- **+1** to approve
+- **0** to abstain or neutral
+- **-1** if issues found (please include details)
 
 ## Timeline
 

.github/workflows/publish-beta.yml

@@ -20,6 +20,7 @@ jobs:
     outputs:
       beta_version: ${{ steps.publish.outputs.BETA_VERSION }}
       beta_tag: ${{ steps.publish.outputs.BETA_TAG }}
+      release_root_tag: ${{ steps.publish.outputs.RELEASE_ROOT_TAG }}
     steps:
     - name: Output Inputs
       run: echo "${{ toJSON(github.event.inputs) }}"

ci/create_major_minor_rc.sh

@@ -69,15 +69,15 @@ if [ "${BREAKING_CHANGES}" = "true" ]; then
 
     if [ "${CURR_MAJOR}" -gt "${BASE_RC_MAJOR}" ]; then
         echo "Major version already bumped from ${BASE_RC_MAJOR} to ${CURR_MAJOR}"
-        RC_VERSION="${BASE_VERSION}-rc.0"
+        RC_VERSION="${BASE_VERSION}-rc.1"
     else
         echo "Breaking changes require major version bump"
         RC_MAJOR=$((CURR_MAJOR + 1))
-        RC_VERSION="${RC_MAJOR}.0.0-rc.0"
+        RC_VERSION="${RC_MAJOR}.0.0-rc.1"
     fi
 else
     # No breaking changes, use current base version
-    RC_VERSION="${BASE_VERSION}-rc.0"
+    RC_VERSION="${BASE_VERSION}-rc.1"
 fi
 
 echo "Creating RC version: ${RC_VERSION}"

ci/publish_beta.sh

@@ -76,7 +76,7 @@ if [[ "${BRANCH}" == "main" ]] && [[ "${CURRENT_VERSION}" =~ -beta\.[0-9]+$ ]];
         PREV_BASE_VERSION=$(echo "${CURRENT_VERSION}" | sed 's/-beta\.[0-9]*$//')
         # Decrement major to get what the "RC" would have been
         PREV_MAJOR=$((NEXT_MAJOR - 1))
-        BASE_RC_VERSION="${PREV_MAJOR}.${CURR_MINOR}.${CURR_PATCH}-rc.0"
+        BASE_RC_VERSION="${PREV_MAJOR}.${CURR_MINOR}.${CURR_PATCH}-rc.1"
         git tag -a "${NEW_RELEASE_ROOT_TAG}" "${PREV_COMMIT}" -m "Base: ${BASE_RC_VERSION}
 Release root for ${NEXT_VERSION}-beta.N series (created during major bump)"
 

release_process.md

@@ -76,9 +76,9 @@ flowchart LR
 
     subgraph release["Release Branch: release/v1.3"]
         direction LR
-        R1["1.3.0-rc.0<br/>🏷️ v1.3.0-rc.0"] --> R2["1.3.0<br/>🏷️ v1.3.0"]
+        R1["1.3.0-rc.1<br/>🏷️ v1.3.0-rc.1"] --> R2["1.3.0<br/>🏷️ v1.3.0"]
         R2 --> R3["1.3.1-beta.0"]
-        R3 --> R4["1.3.1-rc.0<br/>🏷️ v1.3.1-rc.0"]
+        R3 --> R4["1.3.1-rc.1<br/>🏷️ v1.3.1-rc.1"]
         R4 --> R5["1.3.1<br/>🏷️ v1.3.1"]
         R5 --> R6["1.3.2-beta.0"]
     end
@@ -87,10 +87,10 @@ flowchart LR
 ```
 
 **Flow explanation:**
-- **Main branch** at `1.3.0-beta.2` (has release-root tag) → create RC checks for breaking changes → if none, RC is `1.3.0-rc.0`, main bumps to `1.4.0-beta.0` with new release-root tag → `1.4.0-beta.1` (preview, tagged) → create RC for v1.4.0 → main bumps to `1.5.0-beta.0`
-- **Release branch** `release/v1.3` created from main at `1.3.0-beta.2`, starts at `1.3.0-rc.0` (tagged) → `1.3.0` (stable, tagged) → `1.3.1-beta.0` → `1.3.1-rc.0` (tagged) → `1.3.1` (stable, tagged) → `1.3.2-beta.0`
+- **Main branch** at `1.3.0-beta.2` (has release-root tag) → create RC checks for breaking changes → if none, RC is `1.3.0-rc.1`, main bumps to `1.4.0-beta.0` with new release-root tag → `1.4.0-beta.1` (preview, tagged) → create RC for v1.4.0 → main bumps to `1.5.0-beta.0`
+- **Release branch** `release/v1.3` created from main at `1.3.0-beta.2`, starts at `1.3.0-rc.1` (tagged) → `1.3.0` (stable, tagged) → `1.3.1-beta.0` → `1.3.1-rc.1` (tagged) → `1.3.1` (stable, tagged) → `1.3.2-beta.0`
 - **Tags**: 🏷️ = version tag, 📍 = release-root tag (for breaking change detection)
-- **Breaking changes**: If breaking changes detected when cutting RC from `1.3.0-beta.2`, the RC would be `2.0.0-rc.0` and main would bump to `2.1.0-beta.0`
+- **Breaking changes**: If breaking changes detected when cutting RC from `1.3.0-beta.2`, the RC would be `2.0.0-rc.1` and main would bump to `2.1.0-beta.0`
 
 **Note**: All commits are linear on their respective branches. `beta.0` = unreleased, `beta.1+` = published previews.
 
@@ -114,19 +114,20 @@ Trigger the **"Publish Beta"** workflow:
 - **dry_run**: Test first with `true`
 
 This workflow:
-- For main branch at `beta.0` (unreleased): Checks for breaking changes and bumps version accordingly
-  - **Breaking changes found**: Bumps to next major `beta.1` (e.g., `1.4.0-beta.0` → `2.0.0-beta.1`)
-  - **No breaking changes**: Keep current version, bump to `beta.1` (e.g., `1.4.0-beta.0` → `1.4.0-beta.1`)
-- For other beta versions: Bumps beta prerelease number (`beta.N` → `beta.N+1`)
+- For main branch: Checks for breaking changes and bumps version accordingly
+  - **Breaking changes found AND current major == base major**: Bumps to next major `beta.1` (e.g., `1.4.0-beta.1` → `2.0.0-beta.1`)
+  - **Breaking changes found AND current major > base major**: Already bumped, just increment beta (e.g., `2.0.0-beta.1` → `2.0.0-beta.2`)
+  - **No breaking changes**: Keep current major, bump to next beta (e.g., `1.4.0-beta.0` → `1.4.0-beta.1`)
+- For release branches: Bumps beta prerelease number (`beta.N` → `beta.N+1`)
 - Creates beta tag
-- Publishes artifacts to fury.io
+- Publishes artifacts
 
-**Note**: The version was already incremented during RC creation, so without breaking changes we just convert `beta.0` to `beta.1`.
+**Note**: Breaking change detection happens on every beta publish from main. Major version bumps occur when breaking changes are first detected, and the major version is only bumped once per breaking change detection cycle.
 
 **Use cases**:
 - Testing features before RC
 - Regular preview releases for early adopters
-- Converting unreleased beta.0 to published beta.1 (triggers breaking change detection on main)
+- Incremental beta releases with automatic breaking change detection
 
 ## Breaking Change Detection
 
@@ -142,12 +143,12 @@ Release root tags mark the base commits for breaking change detection. The tag n
 **Tag Format**: `release-root/{major}.{minor}.{patch}-beta.N`
 - The tag name indicates which beta version series uses this base
 - The tag points to the commit on main branch before the RC was created (the comparison base)
-- The tag message stores the base RC version (e.g., "Base: 1.3.0-rc.0") - this is what we compare against to detect major version bumps
+- The tag message stores the base RC version (e.g., "Base: 1.3.0-rc.1") - this is what we compare against to detect major version bumps
 - The base RC version in the message stays constant even when multiple release-root tags point to the same commit
 
 **When created**:
 1. **When creating a major/minor RC**: After bumping main to the next version
-   - Example: After cutting v1.3.0-rc.1, create `release-root/1.4.0-beta.N` pointing to the RC commit
+   - Example: After cutting v1.3.0-rc.1, create `release-root/1.4.0-beta.N` pointing to the commit before the RC branch was created (the last commit on main before branching)
 2. **When breaking changes bump major version**: When major version is bumped during beta publish
    - Example: When bumping 1.4.0-beta.5 → 2.0.0-beta.1, create `release-root/2.0.0-beta.N` pointing to the SAME commit with the SAME base RC version
 
@@ -164,7 +165,7 @@ Breaking change detection happens **on every beta publish from main branch**. Th
 
 1. **Find release-root tag**: Look for `release-root/{current_version}-beta.N`
    - If NOT found → Bump to next major immediately (no comparison base exists)
-2. **Extract base RC version**: Read from tag message (e.g., "Base: 1.3.0-rc.0" → base major is `1`)
+2. **Extract base RC version**: Read from tag message (e.g., "Base: 1.3.0-rc.1" → base major is `1`)
 3. **Compare**: Check for breaking changes since the commit pointed to by the release-root tag
 4. **Determine action**:
    - If breaking changes AND current_major == base_major → bump to next major
@@ -173,10 +174,10 @@ Breaking change detection happens **on every beta publish from main branch**. Th
 
 **Examples:**
 
-Starting from v1.3.0-rc.0 cut, main at 1.4.0-beta.0 with `release-root/1.4.0-beta.N` (Base: 1.3.0-rc.0):
+Starting from v1.3.0-rc.1 cut, main at 1.4.0-beta.0 with `release-root/1.4.0-beta.N` (Base: 1.3.0-rc.1):
 - `1.4.0-beta.0` + no breaking → `1.4.0-beta.1`
 - `1.4.0-beta.1` + breaking → `2.0.0-beta.1`
-  - Creates `release-root/2.0.0-beta.N` pointing to same commit, message still "Base: 1.3.0-rc.0"
+  - Creates `release-root/2.0.0-beta.N` pointing to same commit, message still "Base: 1.3.0-rc.1"
   - Base major from tag message is 1, current major is 1, so bump to 2
 - `2.0.0-beta.1` + breaking → `2.0.0-beta.2`
   - Base major from `release-root/2.0.0-beta.N` tag message is 1, current major is 2
@@ -187,7 +188,7 @@ Starting from v1.3.0-rc.0 cut, main at 1.4.0-beta.0 with `release-root/1.4.0-bet
 - `1.4.0-beta.1` but `release-root/1.4.0-beta.N` doesn't exist → `2.0.0-beta.1`
   - No comparison base, automatically bump to next major
   - Creates `release-root/2.0.0-beta.N` pointing to the commit before the version bump
-  - Tag message: "Base: 1.4.0-rc.0" (the hypothetical RC version we're comparing against)
+  - Tag message: "Base: 1.4.0-rc.1" (the hypothetical RC version we're comparing against)
   - Future beta publishes from 2.0.0 series will compare against this base
   - Useful for migration or when starting fresh
 
@@ -238,20 +239,20 @@ This workflow:
 - Reads current version from main (e.g., `1.3.0-beta.2`)
 - Checks for breaking changes since the release-root tag
 - If breaking changes detected:
-  - Creates RC with bumped major version: `2.0.0-rc.0`
+  - Creates RC with bumped major version: `2.0.0-rc.1`
   - Bumps main to: `2.1.0-beta.0`
 - If no breaking changes:
-  - Creates RC with current version: `1.3.0-rc.0`
+  - Creates RC with current version: `1.3.0-rc.1`
   - Bumps main to: `1.4.0-beta.0`
 - Creates `release/v{major}.{minor}` branch from main HEAD
-- Tags the RC: `v{version}-rc.0`
-- Creates `release-root/{next_version}-beta.N` tag at the RC commit for future breaking change comparison
+- Tags the RC: `v{version}-rc.1`
+- Creates `release-root/{next_version}-beta.N` tag at the commit before the RC branch (for future breaking change comparison)
 - Creates GitHub Discussion for voting
 
 **Important**:
 - Always creates RC from the tip of main branch (HEAD)
-- Breaking change detection happens during RC creation, not during beta publish
-- If breaking changes are found, both RC and next main version get major version bump
+- Breaking change detection happens during both RC creation AND beta publish
+- If breaking changes are found during RC creation, both RC and next main version get major version bump
 
 ### Step 2: Vote on Release Candidate
 
@@ -343,7 +344,7 @@ Workflow: Publish Beta
   branch: main
   Result:
     - Looks for release-root/1.4.0-beta.N → found
-    - Extracts base: 1.3.0-rc.0 (major: 1) from tag message
+    - Extracts base: 1.3.0-rc.1 (major: 1) from tag message
     - No breaking changes detected
     - Bumped to 1.4.0-beta.1
     - Tagged v1.4.0-beta.1
@@ -354,10 +355,10 @@ Workflow: Publish Beta
   branch: main
   Result:
     - Looks for release-root/1.4.0-beta.N → found
-    - Extracts base: 1.3.0-rc.0 (major: 1) from tag message
+    - Extracts base: 1.3.0-rc.1 (major: 1) from tag message
     - Breaking changes detected, current major (1) == base major (1)
     - Bumped to 2.0.0-beta.1 (beta resets on major bump)
-    - Created release-root/2.0.0-beta.N → same commit, message "Base: 1.3.0-rc.0"
+    - Created release-root/2.0.0-beta.N → same commit, message "Base: 1.3.0-rc.1"
     - Tagged v2.0.0-beta.1
     - Published artifacts
 
@@ -366,7 +367,7 @@ Workflow: Publish Beta
   branch: main
   Result:
     - Looks for release-root/2.0.0-beta.N → found
-    - Extracts base: 1.3.0-rc.0 (major: 1) from tag message
+    - Extracts base: 1.3.0-rc.1 (major: 1) from tag message
     - Breaking changes detected, but current major (2) > base major (1)
     - No major bump needed (already bumped)
     - Bumped to 2.0.0-beta.2
@@ -383,10 +384,10 @@ Workflow: Create Major/Minor RC
   Result:
     - Checks for breaking changes since release-root/1.3.0-beta.N
     - No breaking changes detected
-    - Created release/v1.3 at 1.3.0-rc.0
-    - Tagged v1.3.0-rc.0
+    - Created release/v1.3 at 1.3.0-rc.1
+    - Tagged v1.3.0-rc.1
     - Bumped main to 1.4.0-beta.0 (unreleased)
-    - Tagged release-root/1.4.0-beta.N → points to commit before RC branch, message "Base: 1.3.0-rc.0"
+    - Tagged release-root/1.4.0-beta.N → points to commit before RC branch, message "Base: 1.3.0-rc.1"
     - GitHub Discussion created
 
 # 3. Vote on RC
@@ -396,7 +397,7 @@ Workflow: Create Major/Minor RC
 
 # 4. Promote to stable
 Workflow: Promote RC to Stable
-  rc_tag: v1.3.0-rc.0
+  rc_tag: v1.3.0-rc.1
   Result:
     - release/v1.3 @ 1.3.0 (stable)
     - Tagged v1.3.0
@@ -409,7 +410,7 @@ Workflow: Publish Beta
   branch: main
   Result:
     - Looks for release-root/1.4.0-beta.N → found
-    - Extracts base: 1.3.0-rc.0 (major: 1) from tag message
+    - Extracts base: 1.3.0-rc.1 (major: 1) from tag message
     - No breaking changes detected
     - Bumped from 1.4.0-beta.0 to 1.4.0-beta.1
     - Tagged v1.4.0-beta.1
@@ -420,10 +421,10 @@ Workflow: Publish Beta
   branch: main
   Result:
     - Looks for release-root/1.4.0-beta.N → found
-    - Extracts base: 1.3.0-rc.0 (major: 1) from tag message
+    - Extracts base: 1.3.0-rc.1 (major: 1) from tag message
     - Breaking changes detected, current major (1) == base major (1)
     - Bumped from 1.4.0-beta.1 to 2.0.0-beta.1 (beta resets on major bump)
-    - Created release-root/2.0.0-beta.N → same commit, message "Base: 1.3.0-rc.0"
+    - Created release-root/2.0.0-beta.N → same commit, message "Base: 1.3.0-rc.1"
     - Tagged v2.0.0-beta.1
     - Published artifacts
 
@@ -432,7 +433,7 @@ Workflow: Publish Beta
   branch: main
   Result:
     - Looks for release-root/2.0.0-beta.N → found
-    - Extracts base: 1.3.0-rc.0 (major: 1) from tag message
+    - Extracts base: 1.3.0-rc.1 (major: 1) from tag message
     - Breaking changes detected, but current major (2) > base major (1)
     - No major bump needed (already bumped from base)
     - Bumped to 2.0.0-beta.2
@@ -445,10 +446,10 @@ Workflow: Create Major/Minor RC
     - Main at 2.0.0-beta.2
     - Checks for breaking changes since release-root/2.0.0-beta.N
     - No additional breaking changes (major already bumped)
-    - Created release/v2.0 at 2.0.0-rc.0
-    - Tagged v2.0.0-rc.0
+    - Created release/v2.0 at 2.0.0-rc.1
+    - Tagged v2.0.0-rc.1
     - Bumped main to 2.1.0-beta.0
-    - Tagged release-root/2.1.0-beta.N → points to commit before RC branch, message "Base: 2.0.0-rc.0"
+    - Tagged release-root/2.1.0-beta.N → points to commit before RC branch, message "Base: 2.0.0-rc.1"
 ```
 
 ### Patch Release
@@ -462,13 +463,13 @@ Workflow: Create RC
   release_branch: release/v1.3
   Result:
     - Branch at 1.3.1-beta.0
-    - Created 1.3.1-rc.0
-    - Tagged v1.3.1-rc.0
+    - Created 1.3.1-rc.1
+    - Tagged v1.3.1-rc.1
 
 # 5. Vote passes
 # 6. Promote patch RC
 Workflow: Promote RC to Stable
-  rc_tag: v1.3.1-rc.0
+  rc_tag: v1.3.1-rc.1
   Result:
     - release/v1.3 @ 1.3.1
     - Tagged v1.3.1
@@ -481,22 +482,22 @@ Workflow: Promote RC to Stable
 
 ```bash
 # 1. Create initial RC
-RC: v1.3.0-rc.0 on release/v1.3
+RC: v1.3.0-rc.1 on release/v1.3
 
 # 2. Issue found during testing
 # 3. Fix committed to release/v1.3 branch
 # 4. Create new RC
 Workflow: Create RC
   release_branch: release/v1.3
   Result:
-    - Branch at 1.3.0-rc.0
-    - Auto-incremented to 1.3.0-rc.1
-    - Tagged v1.3.0-rc.1
+    - Branch at 1.3.0-rc.1
+    - Auto-incremented to 1.3.0-rc.2
+    - Tagged v1.3.0-rc.2
 
 # 5. Vote passes
-# 6. Promote rc.1 to stable
+# 6. Promote rc.2 to stable
 Workflow: Promote RC to Stable
-  rc_tag: v1.3.0-rc.1
+  rc_tag: v1.3.0-rc.2
   Result:
     - release/v1.3 @ 1.3.0
     - Tagged v1.3.0