Skip to content

ActionManager context variable is never used. #145

@julianstirling

Description

@julianstirling

The code currently has two action manager dependencies:

  1. ActionManagerDep - a standard dependency that returns the Action manger
  2. ActionManagerContextDep - A dependency that calls the above dependency to set the action manger to a context variable. Allowing ActionManagerContext.get()

The code always ActionManagerContextDep, however it also always uses the the action manager directly returned by it rather than using ActionManagerContext.get().

I don't really see the advantage of the context var here. I feel the code is more explicit and testable without a context variable, as ActionManagerContext.get() is never used it should be simple to remove ActionManagerContextDep and change all call to it to ActionManagerDep?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions