-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Milestone
Description
The code currently has two action manager dependencies:
ActionManagerDep- a standard dependency that returns the Action mangerActionManagerContextDep- A dependency that calls the above dependency to set the action manger to a context variable. AllowingActionManagerContext.get()
The code always ActionManagerContextDep, however it also always uses the the action manager directly returned by it rather than using ActionManagerContext.get().
I don't really see the advantage of the context var here. I feel the code is more explicit and testable without a context variable, as ActionManagerContext.get() is never used it should be simple to remove ActionManagerContextDep and change all call to it to ActionManagerDep?
Metadata
Metadata
Assignees
Labels
No labels