Permissions issues in repo

[justinsb]

Many of the people working on the repo are hitting prow permissions, so I said I would take a look to try to unblock some people.

Ideally we want:

• The people working on the extensions (SandboxClaim, Python SDK) to be OWNERS of those areas, with approval rights
• Everyone working on the project should be able to LGTM using the /lgtm prow command
• We do want to broaden the pool of top-level approvers also (using the /approve prow command)

[justinsb]

Tthe "changing LGTM is restricted to collaborators" message comes from here:

https://github.com/kubernetes-sigs/prow/blob/148e9cff413a4991afc19aac6da5a4d44c0429b9/pkg/plugins/lgtm/lgtm.go#L292

Collaborator looks to be defined here: https://github.com/kubernetes-sigs/prow/blob/main/pkg/github/client.go#L4022

If you have the gh CLI installed you can check if someone is a collaborator using:

gh api --verbose repos/kubernetes-sigs/agent-sandbox/collaborators/justinsb

[justinsb]

I suspect based on that that getting membership of kubernetes-sigs is going to make life much easier.

Looks like that's a two step process:

1. Get kubernetes org membership (bottleneck for most people will probably be finding sponsors from two companies ): https://github.com/kubernetes/community/blob/master/github-management/new-membership-procedure.md#adding-a-new-member-to-a-kubernetes-github-org

2. Get membership in kubernetes-sigs (which does not require approvals, but is another step): https://github.com/kubernetes/community/blob/master/community-membership.md#kubernetes-ecosystem

[justinsb]

Looks like the membership of kubernetes-sigs is here, and of kubernetes is here