test: Remove outdated spotbugs warning suppressions

Author: kohlschuetter

junixsocket-common/src/test/java/org/newsclub/net/unix/AcceptTimeoutTest.java

@@ -37,7 +37,6 @@
 import org.junit.jupiter.api.Test;
 import org.opentest4j.AssertionFailedError;
 
-import com.kohlschutter.annotations.compiletime.SuppressFBWarnings;
 import com.kohlschutter.testutil.TestAbortedWithImportantMessageException;
 import com.kohlschutter.testutil.TestAbortedWithImportantMessageException.MessageType;
 import com.kohlschutter.testutil.TestAsyncUtil;
@@ -48,8 +47,6 @@
  *
  * @author Christian Kohlschütter
  */
-@SuppressFBWarnings({
-    "THROWS_METHOD_THROWS_CLAUSE_THROWABLE", "THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION"})
 public abstract class AcceptTimeoutTest<A extends SocketAddress> extends SocketTestBase<A> {
   private static final int TIMING_INACCURACY_MILLIS = 5000;
 
@@ -90,7 +87,6 @@ public void testCatchTimeout() throws Exception {
 
   @Test
   @SuppressWarnings({"PMD.CognitiveComplexity", "PMD.ExcessiveMethodLength"})
-  @SuppressFBWarnings("NP_NONNULL_PARAM_VIOLATION")
   public void testTimeoutAfterDelay() throws Exception {
     final int timeoutMillis = 5000;
 

junixsocket-common/src/test/java/org/newsclub/net/unix/AvailableTest.java

@@ -29,10 +29,6 @@
 
 import org.junit.jupiter.api.Test;
 
-import com.kohlschutter.annotations.compiletime.SuppressFBWarnings;
-
-@SuppressFBWarnings({
-    "THROWS_METHOD_THROWS_CLAUSE_THROWABLE", "THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION"})
 public abstract class AvailableTest<A extends SocketAddress> extends SocketTestBase<A> {
   private static final int BYTES_SENT = 23;
   private static final int TIME_TO_SLEEP = 100;

junixsocket-common/src/test/java/org/newsclub/net/unix/BufferOverflowTest.java

@@ -43,9 +43,7 @@
 /**
  * See <a href="https://code.google.com/archive/p/junixsocket/issues/20">Issue 20</a>.
  */
-@SuppressFBWarnings({
-    "THROWS_METHOD_THROWS_CLAUSE_THROWABLE", "THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION",
-    "RANGE_ARRAY_LENGTH"})
+@SuppressFBWarnings({"RANGE_ARRAY_LENGTH"})
 // CPD-OFF - Skip code-duplication checks
 public abstract class BufferOverflowTest<A extends SocketAddress> extends SocketTestBase<A> {
   private ServerSocket server;

junixsocket-common/src/test/java/org/newsclub/net/unix/CancelAcceptTest.java

@@ -31,7 +31,6 @@
 
 import org.junit.jupiter.api.Test;
 
-import com.kohlschutter.annotations.compiletime.SuppressFBWarnings;
 import com.kohlschutter.testutil.TestAbortedWithImportantMessageException;
 import com.kohlschutter.testutil.TestAbortedWithImportantMessageException.MessageType;
 import com.kohlschutter.testutil.TestStackTraceUtil;
@@ -41,8 +40,6 @@
  *
  * @see <a href="https://code.google.com/archive/p/junixsocket/issues/6">Issue 6</a>
  */
-@SuppressFBWarnings({
-    "THROWS_METHOD_THROWS_CLAUSE_THROWABLE", "THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION"})
 public abstract class CancelAcceptTest<A extends SocketAddress> extends SocketTestBase<A> {
   protected static final String NO_SOCKETEXCEPTION_CLOSED_SERVER =
       "Did not throw SocketException when connecting to closed server socket";

junixsocket-common/src/test/java/org/newsclub/net/unix/DatagramSocketTest.java

@@ -41,13 +41,10 @@
 import org.junit.jupiter.api.Test;
 import org.opentest4j.AssertionFailedError;
 
-import com.kohlschutter.annotations.compiletime.SuppressFBWarnings;
 import com.kohlschutter.testutil.TestAbortedWithImportantMessageException;
 import com.kohlschutter.testutil.TestAbortedWithImportantMessageException.MessageType;
 
 @AFSocketCapabilityRequirement(AFSocketCapability.CAPABILITY_UNIX_DATAGRAMS)
-@SuppressFBWarnings({
-    "THROWS_METHOD_THROWS_CLAUSE_THROWABLE", "THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION"})
 public abstract class DatagramSocketTest<A extends SocketAddress> extends SocketTestBase<A> {
   protected DatagramSocketTest(AddressSpecifics<A> asp) {
     super(asp);

junixsocket-common/src/test/java/org/newsclub/net/unix/EndOfFileTest.java

@@ -39,15 +39,11 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-import com.kohlschutter.annotations.compiletime.SuppressFBWarnings;
-
 /**
  * See <a href="https://code.google.com/archive/p/junixsocket/issues/9">Issue 9</a>.
  *
  * @author Derrick Rice (April, 2010)
  */
-@SuppressFBWarnings({
-    "THROWS_METHOD_THROWS_CLAUSE_THROWABLE", "THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION"})
 public abstract class EndOfFileTest<A extends SocketAddress> extends SocketTestBase<A> {
   protected ServerSocket server;
   protected ExecutorService executor;

junixsocket-common/src/test/java/org/newsclub/net/unix/FileDescriptorCastTest.java

@@ -49,13 +49,10 @@
 import org.eclipse.jdt.annotation.Nullable;
 import org.junit.jupiter.api.Test;
 
-import com.kohlschutter.annotations.compiletime.SuppressFBWarnings;
 import com.kohlschutter.testutil.TestAbortedNotAnIssueException;
 import com.kohlschutter.util.IOUtil;
 
 @SuppressWarnings("PMD.CouplingBetweenObjects")
-@SuppressFBWarnings({
-    "THROWS_METHOD_THROWS_CLAUSE_THROWABLE", "THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION"})
 public class FileDescriptorCastTest {
   // CPD-OFF
 

junixsocket-common/src/test/java/org/newsclub/net/unix/FinalizeTest.java

@@ -35,7 +35,6 @@
 
 import org.junit.jupiter.api.Test;
 
-import com.kohlschutter.annotations.compiletime.SuppressFBWarnings;
 import com.kohlschutter.testutil.CommandAvailabilityRequirement;
 import com.kohlschutter.testutil.ForkedVM;
 import com.kohlschutter.testutil.ForkedVMRequirement;
@@ -51,8 +50,6 @@
  * @author Christian Kohlschütter
  */
 @CommandAvailabilityRequirement(commands = {"lsof"})
-@SuppressFBWarnings({
-    "THROWS_METHOD_THROWS_CLAUSE_THROWABLE", "THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION"})
 public abstract class FinalizeTest<A extends SocketAddress> extends SocketTestBase<A> {
   private Process process = null;
 

junixsocket-common/src/test/java/org/newsclub/net/unix/FinalizeTestClient.java

@@ -33,11 +33,9 @@
  * @see FinalizeTest
  * @author Christian Kohlschütter
  */
-@SuppressFBWarnings({
-    "THROWS_METHOD_THROWS_CLAUSE_THROWABLE", "THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION"})
 public class FinalizeTestClient {
   @SuppressWarnings({"ModifiedButNotUsed" /* errorprone */})
-  @SuppressFBWarnings({"RV_RETURN_VALUE_IGNORED", "UC_USELESS_OBJECT"})
+  @SuppressFBWarnings({"UC_USELESS_OBJECT"})
   public static void main(String[] args) throws Exception {
     String socketType = System.getProperty("test.junixsocket.socket.type", "");
     String socketName = System.getProperty("test.junixsocket.socket", "");

junixsocket-common/src/test/java/org/newsclub/net/unix/MulticastThroughputTest.java

@@ -0,0 +1,26 @@
+/*
+ * junixsocket
+ *
+ * Copyright 2009-2024 Christian Kohlschütter
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.newsclub.net.unix;
+
+import java.net.SocketAddress;
+
+public class MulticastThroughputTest<A extends SocketAddress> extends SocketTestBase<A> {
+  protected MulticastThroughputTest(AddressSpecifics<A> asp) {
+    super(asp);
+  }
+}