From fb7828d68c1d50621cc9d99187d0aee6c17ad6ca Mon Sep 17 00:00:00 2001 From: Mikolaj Samulak Date: Sat, 22 Feb 2025 23:33:14 +0100 Subject: [PATCH 1/3] feat(exec) Filter by tags in exec cmd --- cmd/util.go | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/cmd/util.go b/cmd/util.go index 759d5be..5f09d7b 100644 --- a/cmd/util.go +++ b/cmd/util.go @@ -23,13 +23,7 @@ func filter(options []string, tag string) (commands []string, err error) { // Filter the snippets by specified tag if any if 0 < len(tag) { var filteredSnippets snippet.Snippets - for _, snippet := range snippets.Snippets { - for _, t := range snippet.Tag { - if tag == t { - filteredSnippets.Snippets = append(filteredSnippets.Snippets, snippet) - } - } - } + filteredSnippets.Snippets = snippets.FilterByTags(strings.Split(tag, ",")) snippets = filteredSnippets } From 33ccdcb9be7b16a0e69df0e41914091aaae97548 Mon Sep 17 00:00:00 2001 From: Mikolaj Samulak Date: Sat, 22 Feb 2025 23:45:10 +0100 Subject: [PATCH 2/3] Update Command Flags --- cmd/exec.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cmd/exec.go b/cmd/exec.go index b923775..d1f2d3a 100644 --- a/cmd/exec.go +++ b/cmd/exec.go @@ -51,8 +51,7 @@ func init() { `Enable colorized output (only fzf)`) execCmd.Flags().StringVarP(&config.Flag.Query, "query", "q", "", `Initial value for query`) - execCmd.Flags().StringVarP(&config.Flag.FilterTag, "tag", "t", "", - `Filter tag`) + execCmd.Flags().StringVarP(&config.Flag.FilterTag, "tags", "t", "", "Filter by specified tags as comma separated values") execCmd.Flags().BoolVarP(&config.Flag.Silent, "silent", "s", false, `Suppress the command output`) } From fd6cf70213ebe654c111c75b1d4b50c0767e6daf Mon Sep 17 00:00:00 2001 From: Mikolaj Samulak Date: Sat, 1 Mar 2025 21:18:23 +0100 Subject: [PATCH 3/3] Other places where filter() is used. --- cmd/clip.go | 4 ++-- cmd/edit.go | 4 ++-- cmd/exec.go | 3 ++- cmd/search.go | 4 ++-- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/cmd/clip.go b/cmd/clip.go index 6f44840..6853cd6 100644 --- a/cmd/clip.go +++ b/cmd/clip.go @@ -45,6 +45,6 @@ func init() { `Display snippets in one line`) clipCmd.Flags().StringVarP(&config.Flag.Delimiter, "delimiter", "d", "; ", `Use delim as the command delimiter character`) - clipCmd.Flags().StringVarP(&config.Flag.FilterTag, "tag", "t", "", - `Filter tag`) + clipCmd.Flags().StringVarP(&config.Flag.FilterTag, "tags", "t", "", + `"Filter by specified tags as comma separated values"`) } diff --git a/cmd/edit.go b/cmd/edit.go index e6310b4..e8304a4 100644 --- a/cmd/edit.go +++ b/cmd/edit.go @@ -73,6 +73,6 @@ func init() { RootCmd.AddCommand(editCmd) editCmd.Flags().StringVarP(&config.Flag.Query, "query", "q", "", `Initial value for query`) - editCmd.Flags().StringVarP(&config.Flag.FilterTag, "tag", "t", "", - `Filter tag`) + editCmd.Flags().StringVarP(&config.Flag.FilterTag, "tags", "t", "", + `"Filter by specified tags as comma separated values"`) } diff --git a/cmd/exec.go b/cmd/exec.go index d1f2d3a..f6a7a4f 100644 --- a/cmd/exec.go +++ b/cmd/exec.go @@ -51,7 +51,8 @@ func init() { `Enable colorized output (only fzf)`) execCmd.Flags().StringVarP(&config.Flag.Query, "query", "q", "", `Initial value for query`) - execCmd.Flags().StringVarP(&config.Flag.FilterTag, "tags", "t", "", "Filter by specified tags as comma separated values") + execCmd.Flags().StringVarP(&config.Flag.FilterTag, "tags", "t", "", + "Filter by specified tags as comma separated values") execCmd.Flags().BoolVarP(&config.Flag.Silent, "silent", "s", false, `Suppress the command output`) } diff --git a/cmd/search.go b/cmd/search.go index 149db45..8e6f01c 100644 --- a/cmd/search.go +++ b/cmd/search.go @@ -43,8 +43,8 @@ func init() { `Enable colorized output (only fzf)`) searchCmd.Flags().StringVarP(&config.Flag.Query, "query", "q", "", `Initial value for query`) - searchCmd.Flags().StringVarP(&config.Flag.FilterTag, "tag", "t", "", - `Filter tag`) + searchCmd.Flags().StringVarP(&config.Flag.FilterTag, "tags", "t", "", + `"Filter by specified tags as comma separated values"`) searchCmd.Flags().StringVarP(&config.Flag.Delimiter, "delimiter", "d", "; ", `Use delim as the command delimiter character`) }