Skip to content

Commit aa7f7d8

Browse files
authored
update deps, prepare release (#184)
1 parent eba8ea0 commit aa7f7d8

File tree

10 files changed

+115
-107
lines changed

10 files changed

+115
-107
lines changed

.github/workflows/dart.yml

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -40,23 +40,23 @@ jobs:
4040
- name: mono_repo self validate
4141
run: dart pub global run mono_repo generate --validate
4242
job_002:
43-
name: "analyzer_and_format; Dart 3.8.0; PKGS: build_cli, build_cli_annotations; `dart analyze --fatal-infos .`"
43+
name: "analyzer_and_format; Dart 3.9.0; PKGS: build_cli, build_cli_annotations; `dart analyze --fatal-infos .`"
4444
runs-on: ubuntu-latest
4545
steps:
4646
- name: Cache Pub hosted dependencies
4747
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830
4848
with:
4949
path: "~/.pub-cache/hosted"
50-
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.8.0;packages:build_cli-build_cli_annotations;commands:analyze"
50+
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.9.0;packages:build_cli-build_cli_annotations;commands:analyze"
5151
restore-keys: |
52-
os:ubuntu-latest;pub-cache-hosted;sdk:3.8.0;packages:build_cli-build_cli_annotations
53-
os:ubuntu-latest;pub-cache-hosted;sdk:3.8.0
52+
os:ubuntu-latest;pub-cache-hosted;sdk:3.9.0;packages:build_cli-build_cli_annotations
53+
os:ubuntu-latest;pub-cache-hosted;sdk:3.9.0
5454
os:ubuntu-latest;pub-cache-hosted
5555
os:ubuntu-latest
5656
- name: Setup Dart SDK
5757
uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
5858
with:
59-
sdk: "3.8.0"
59+
sdk: "3.9.0"
6060
- id: checkout
6161
name: Checkout repository
6262
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3
@@ -81,23 +81,23 @@ jobs:
8181
needs:
8282
- job_001
8383
job_003:
84-
name: "analyzer_and_format; Dart 3.8.0; PKGS: build_cli, build_cli_annotations; `dart format --output=none --set-exit-if-changed .`"
84+
name: "analyzer_and_format; Dart 3.9.0; PKGS: build_cli, build_cli_annotations; `dart format --output=none --set-exit-if-changed .`"
8585
runs-on: ubuntu-latest
8686
steps:
8787
- name: Cache Pub hosted dependencies
8888
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830
8989
with:
9090
path: "~/.pub-cache/hosted"
91-
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.8.0;packages:build_cli-build_cli_annotations;commands:format"
91+
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.9.0;packages:build_cli-build_cli_annotations;commands:format"
9292
restore-keys: |
93-
os:ubuntu-latest;pub-cache-hosted;sdk:3.8.0;packages:build_cli-build_cli_annotations
94-
os:ubuntu-latest;pub-cache-hosted;sdk:3.8.0
93+
os:ubuntu-latest;pub-cache-hosted;sdk:3.9.0;packages:build_cli-build_cli_annotations
94+
os:ubuntu-latest;pub-cache-hosted;sdk:3.9.0
9595
os:ubuntu-latest;pub-cache-hosted
9696
os:ubuntu-latest
9797
- name: Setup Dart SDK
9898
uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
9999
with:
100-
sdk: "3.8.0"
100+
sdk: "3.9.0"
101101
- id: checkout
102102
name: Checkout repository
103103
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3
@@ -204,23 +204,23 @@ jobs:
204204
needs:
205205
- job_001
206206
job_006:
207-
name: "unit_test; Dart 3.8.0; PKG: build_cli; `dart test --run-skipped --tags presubmit-only`"
207+
name: "unit_test; Dart 3.9.0; PKG: build_cli; `dart test --run-skipped --tags presubmit-only`"
208208
runs-on: ubuntu-latest
209209
steps:
210210
- name: Cache Pub hosted dependencies
211211
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830
212212
with:
213213
path: "~/.pub-cache/hosted"
214-
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.8.0;packages:build_cli;commands:test_1"
214+
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.9.0;packages:build_cli;commands:test_1"
215215
restore-keys: |
216-
os:ubuntu-latest;pub-cache-hosted;sdk:3.8.0;packages:build_cli
217-
os:ubuntu-latest;pub-cache-hosted;sdk:3.8.0
216+
os:ubuntu-latest;pub-cache-hosted;sdk:3.9.0;packages:build_cli
217+
os:ubuntu-latest;pub-cache-hosted;sdk:3.9.0
218218
os:ubuntu-latest;pub-cache-hosted
219219
os:ubuntu-latest
220220
- name: Setup Dart SDK
221221
uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
222222
with:
223-
sdk: "3.8.0"
223+
sdk: "3.9.0"
224224
- id: checkout
225225
name: Checkout repository
226226
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3
@@ -240,23 +240,23 @@ jobs:
240240
- job_004
241241
- job_005
242242
job_007:
243-
name: "unit_test; Dart 3.8.0; PKG: build_cli; `dart test`"
243+
name: "unit_test; Dart 3.9.0; PKG: build_cli; `dart test`"
244244
runs-on: ubuntu-latest
245245
steps:
246246
- name: Cache Pub hosted dependencies
247247
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830
248248
with:
249249
path: "~/.pub-cache/hosted"
250-
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.8.0;packages:build_cli;commands:test_0"
250+
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.9.0;packages:build_cli;commands:test_0"
251251
restore-keys: |
252-
os:ubuntu-latest;pub-cache-hosted;sdk:3.8.0;packages:build_cli
253-
os:ubuntu-latest;pub-cache-hosted;sdk:3.8.0
252+
os:ubuntu-latest;pub-cache-hosted;sdk:3.9.0;packages:build_cli
253+
os:ubuntu-latest;pub-cache-hosted;sdk:3.9.0
254254
os:ubuntu-latest;pub-cache-hosted
255255
os:ubuntu-latest
256256
- name: Setup Dart SDK
257257
uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
258258
with:
259-
sdk: "3.8.0"
259+
sdk: "3.9.0"
260260
- id: checkout
261261
name: Checkout repository
262262
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3

analysis_options.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ linter:
1717
- avoid_js_rounded_ints
1818
- avoid_private_typedef_functions
1919
- avoid_redundant_argument_values
20-
- avoid_returning_null
21-
- avoid_returning_null_for_future
2220
- avoid_returning_this
2321
- avoid_setters_without_getters
2422
- avoid_slow_async_io

build_cli/CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
## 2.2.9
2+
3+
- Required `sdk: ^3.9.0`
4+
- Required `analyzer: ^9.0.0`
5+
- Required `build: ^4.0.3`
6+
- Required `source_gen: ^4.1.1`
7+
- Required `source_helper: ^1.3.9`
8+
- Required `yaml: ^3.1.3`
9+
110
## 2.2.8
211

312
- Required `sdk: ^3.8.0`

build_cli/lib/src/arg_info.dart

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import 'package:analyzer/dart/constant/value.dart';
44
import 'package:analyzer/dart/element/element.dart';
5-
import 'package:analyzer/dart/element/element2.dart';
65
import 'package:analyzer/dart/element/type.dart';
76
import 'package:build_cli_annotations/build_cli_annotations.dart';
87
import 'package:source_gen/source_gen.dart';
@@ -37,34 +36,34 @@ final _argInfoCache = Expando<ArgInfo>();
3736

3837
enum ArgType { option, flag, multiOption, rest, wasParsed, command }
3938

40-
const specialTypes = <ArgType, bool Function(FieldElement2)>{
39+
const specialTypes = <ArgType, bool Function(FieldElement)>{
4140
ArgType.rest: _couldBeRestArg,
4241
ArgType.wasParsed: _couldBeWasParsedArg,
4342
ArgType.command: _couldBeCommand,
4443
};
4544

4645
const wasParsedSuffix = 'WasParsed';
4746

48-
bool _couldBeRestArg(FieldElement2 element) => element.name3 == 'rest';
47+
bool _couldBeRestArg(FieldElement element) => element.name == 'rest';
4948

50-
bool _couldBeWasParsedArg(FieldElement2 element) =>
51-
element.name3!.endsWith(wasParsedSuffix) &&
52-
element.name3!.length > wasParsedSuffix.length &&
49+
bool _couldBeWasParsedArg(FieldElement element) =>
50+
element.name!.endsWith(wasParsedSuffix) &&
51+
element.name!.length > wasParsedSuffix.length &&
5352
boolChecker.isAssignableFromType(element.type);
5453

55-
bool _couldBeCommand(FieldElement2 element) =>
56-
element.name3 == 'command' &&
54+
bool _couldBeCommand(FieldElement element) =>
55+
element.name == 'command' &&
5756
_argResultsChecker.isAssignableFromType(element.type);
5857

5958
class ArgInfo {
6059
final CliOption? optionData;
6160
final ArgType argType;
6261
final DartType dartType;
6362

64-
ArgInfo(this.argType, this.optionData, FieldElement2 element)
63+
ArgInfo(this.argType, this.optionData, FieldElement element)
6564
: dartType = element.type;
6665

67-
static ArgInfo fromField(FieldElement2 element) {
66+
static ArgInfo fromField(FieldElement element) {
6867
final info = _argInfoCache[element];
6968
if (info != null) {
7069
return info;
@@ -120,7 +119,7 @@ class ArgInfo {
120119
}
121120
}
122121

123-
ArgType _getArgType(FieldElement2 element, CliOption option) {
122+
ArgType _getArgType(FieldElement element, CliOption option) {
124123
final targetType = element.type;
125124

126125
if (converterDataFromOptions(option) != null) {
@@ -148,10 +147,10 @@ ArgType _getArgType(FieldElement2 element, CliOption option) {
148147
);
149148
}
150149

151-
CliOption? _getOptions(FieldElement2 element) {
150+
CliOption? _getOptions(FieldElement element) {
152151
final obj =
153152
_cliOptionChecker.firstAnnotationOfExact(element) ??
154-
_cliOptionChecker.firstAnnotationOfExact(element.getter2!);
153+
_cliOptionChecker.firstAnnotationOfExact(element.getter!);
155154

156155
List<Object>? allowedValues;
157156
Object? defaultsTo;
@@ -179,7 +178,7 @@ CliOption? _getOptions(FieldElement2 element) {
179178
p.returnType.toStringNonNullable() ==
180179
element.type.toStringNonNullable(),
181180
)
182-
.map((p) => p.name3!)
181+
.map((p) => p.name!)
183182
.toList();
184183

185184
if (defaultsToReader != null && !defaultsToReader.isNull) {
@@ -307,7 +306,7 @@ CliOption? _getOptions(FieldElement2 element) {
307306
if (formalParams.isEmpty ||
308307
formalParams.first.isNamed ||
309308
formalParams.where((pe) => !pe.isOptional).length > 1 ||
310-
!element.library2.typeProvider.stringType.isAssignableTo(
309+
!element.library.typeProvider.stringType.isAssignableTo(
311310
formalParams.first.type,
312311
)) {
313312
throwUnsupported(
@@ -327,7 +326,7 @@ CliOption? _getOptions(FieldElement2 element) {
327326
);
328327
}
329328
_convertName[option] = ConverterData(
330-
functionElement.name3!,
329+
functionElement.name!,
331330
formalParams.first.type.isNullableType,
332331
);
333332
}

build_cli/lib/src/build_cli_generator.dart

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import 'dart:async';
44
import 'dart:collection';
55

6-
import 'package:analyzer/dart/element/element2.dart';
6+
import 'package:analyzer/dart/element/element.dart';
77
import 'package:analyzer/dart/element/nullability_suffix.dart';
88
import 'package:analyzer/dart/element/type.dart';
99
import 'package:build/build.dart' show BuildStep, log;
@@ -26,13 +26,13 @@ class CliGenerator extends GeneratorForAnnotation<CliOptions> {
2626

2727
@override
2828
Stream<String> generateForAnnotatedElement(
29-
Element2 element,
29+
Element element,
3030
ConstantReader annotation,
3131
BuildStep buildStep,
3232
) async* {
3333
await validateSdkConstraint(buildStep);
3434

35-
if (element is! ClassElement2) {
35+
if (element is! ClassElement) {
3636
final friendlyName = element.displayName;
3737
throw InvalidGenerationSourceError(
3838
'Generator cannot target `$friendlyName`. '
@@ -47,16 +47,16 @@ class CliGenerator extends GeneratorForAnnotation<CliOptions> {
4747
final fieldsList = createSortedFieldSet(element);
4848

4949
// Explicitly using `LinkedHashMap` – we want these ordered.
50-
final fields = LinkedHashMap<String, FieldElement2>.fromIterable(
50+
final fields = LinkedHashMap<String, FieldElement>.fromIterable(
5151
fieldsList,
52-
key: (f) => (f as FieldElement2).name3!,
52+
key: (f) => (f as FieldElement).name!,
5353
);
5454

5555
// Get the constructor to use for the factory
5656

57-
final populateParserName = '_\$populate${element.name3}Parser';
58-
final parserFieldName = '_\$parserFor${element.name3}';
59-
final resultParserName = '_\$parse${element.name3}Result';
57+
final populateParserName = '_\$populate${element.name}Parser';
58+
final parserFieldName = '_\$parserFor${element.name}';
59+
final resultParserName = '_\$parse${element.name}Result';
6060

6161
if (fieldsList.any((fe) => fe.type.isEnum)) {
6262
yield enumValueHelper;
@@ -85,7 +85,7 @@ T _$badNumberFormat<T extends num>(
8585

8686
var buffer = StringBuffer()
8787
..write('''
88-
${element.name3} $resultParserName(ArgResults result) =>''');
88+
${element.name} $resultParserName(ArgResults result) =>''');
8989

9090
String deserializeForField(
9191
String fieldName, {
@@ -96,7 +96,7 @@ ${element.name3} $resultParserName(ArgResults result) =>''');
9696
buffer,
9797
element,
9898
fields.keys,
99-
fields.values.where((fe) => !fe.isFinal).map((fe) => fe.name3!),
99+
fields.values.where((fe) => !fe.isFinal).map((fe) => fe.name!),
100100
{},
101101
deserializeForField,
102102
);
@@ -166,7 +166,7 @@ ${element.name3} $resultParserName(ArgResults result) =>''');
166166
yield 'final $parserFieldName = $populateParserName(ArgParser());';
167167

168168
yield '''
169-
${element.name3} parse${element.name3}(List<String> args) {
169+
${element.name} parse${element.name}(List<String> args) {
170170
final result = $parserFieldName.parse(args);
171171
return $resultParserName(result);
172172
}
@@ -175,8 +175,8 @@ ${element.name3} parse${element.name3}(List<String> args) {
175175
final createCommand = annotation.read('createCommand').boolValue;
176176
if (createCommand) {
177177
yield '''
178-
abstract class _\$${element.name3}Command<T> extends Command<T> {
179-
_\$${element.name3}Command() {
178+
abstract class _\$${element.name}Command<T> extends Command<T> {
179+
_\$${element.name}Command() {
180180
$populateParserName(argParser);
181181
}
182182
@@ -196,9 +196,9 @@ final _numCheckers = <TypeChecker, String>{
196196
};
197197

198198
String _deserializeForField(
199-
FieldElement2 field,
199+
FieldElement field,
200200
FormalParameterElement? ctorParam,
201-
Map<String, FieldElement2> allFields,
201+
Map<String, FieldElement> allFields,
202202
) {
203203
final info = ArgInfo.fromField(field);
204204

@@ -207,7 +207,7 @@ String _deserializeForField(
207207
}
208208

209209
if (info.argType == ArgType.wasParsed) {
210-
final name = field.name3!;
210+
final name = field.name!;
211211
assert(name.endsWith(wasParsedSuffix));
212212
final targetFieldName = name.substring(
213213
0,
@@ -301,13 +301,13 @@ String _deserializeForField(
301301
throwUnsupported(field, 'The type `$targetType` is not supported.');
302302
}
303303

304-
String _getArgName(FieldElement2 element) =>
305-
ArgInfo.fromField(element).optionData?.name ?? element.name3!.kebab;
304+
String _getArgName(FieldElement element) =>
305+
ArgInfo.fromField(element).optionData?.name ?? element.name!.kebab;
306306

307-
String _getArgNameStringLiteral(FieldElement2 element) =>
307+
String _getArgNameStringLiteral(FieldElement element) =>
308308
escapeDartString(_getArgName(element));
309309

310-
void _parserOptionFor(StringBuffer buffer, FieldElement2 element) {
310+
void _parserOptionFor(StringBuffer buffer, FieldElement element) {
311311
final info = ArgInfo.fromField(element);
312312

313313
switch (info.argType) {
@@ -345,10 +345,10 @@ void _parserOptionFor(StringBuffer buffer, FieldElement2 element) {
345345
if (info.dartType.isEnum) {
346346
defaultsToValues.add(
347347
'${enumConstMapName(element.type)}'
348-
'[${_overrideParamName(element.name3!)}]',
348+
'[${_overrideParamName(element.name!)}]',
349349
);
350350
} else {
351-
defaultsToValues.add(_overrideParamName(element.name3!));
351+
defaultsToValues.add(_overrideParamName(element.name!));
352352
}
353353
}
354354

0 commit comments

Comments
 (0)