Skip to content

feature: Handle imagePullSecrets #181

@ntnn

Description

@ntnn

Feature Description

Currently imagePullSecrets are discarded instead of passed on to Deployments:

// TODO: Why do we discard the imagePullSecrets?
image, _ := resources.GetImageSettings(server.Spec.Image)

This is equivalent in other deployment generators.

Proposed Solution

Pass imagePullSecrets from the RootShard/Shard/FrontProxy spec to the Deployment

Alternative Solutions

No response

Want to contribute?

  • I would like to work on this issue.

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions