Skip to content

Merge KaraokeEvent.UsernameSet and the client-to-server KaraokeEvent.RoomDataHydration #16

@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Following #9: there are two initial messages sent from a client to the server when it joins a room:

  1. KaraokeEvent.RoomDataHydration: A request for the basic room data, made in DynamicSceneHydrating -> useRoomDataConnection.
  2. KaraokeEvent.UsernameSet: Indicates to the server what the client username is. No response is waited for.

For the sake of simplicity & fewer messages, we should really join these two into a single one, named something like KaraokeNite.RoomJoin. The client can then send the username in step 1 and still hydrate room data in that same step -- instead of waiting until step 2 to set username.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: game runtimeImprovements to the core game experience.good first issueYou can do this as a way to learn about the code! ❤status: accepting prsThis issue is ready for a pull request.type: cleanupImproving the structural quality of code or runtime smoothness/performance.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions