Skip to content

Commit a6c6cd1

Browse files
committed
Fix panic in test cleanup when client is unset
Signed-off-by: Brad Davidson <[email protected]>
1 parent 6840e43 commit a6c6cd1

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

pkg/etcd/etcd.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1241,8 +1241,10 @@ func (e *ETCD) manageLearners(ctx context.Context) {
12411241
return
12421242
}
12431243

1244+
client := e.client
1245+
12441246
endpoints := getEndpoints(e.config)
1245-
if status, err := e.client.Status(ctx, endpoints[0]); err != nil {
1247+
if status, err := client.Status(ctx, endpoints[0]); err != nil {
12461248
logrus.Errorf("Failed to check local etcd status for learner management: %v", err)
12471249
return
12481250
} else if status.Header.MemberId != status.Leader {
@@ -1255,7 +1257,7 @@ func (e *ETCD) manageLearners(ctx context.Context) {
12551257
return
12561258
}
12571259

1258-
members, err := e.client.MemberList(ctx)
1260+
members, err := client.MemberList(ctx)
12591261
if err != nil {
12601262
logrus.Errorf("Failed to get etcd members for learner management: %v", err)
12611263
return

0 commit comments

Comments
 (0)