JPH_OVERRIDE_NEW_DELETE crash When Creating Classes With "new" keyword

[GreggoryAddison-AntiHeroGameStudio]

This one is super confusing. I have a global subsystem that uses the "new" keyword often I get no asserts. However, when I use the new keyword (this happens with multiple Jolt classes) from a component class I get a crash within the macro in the title.

This is the code I'm calling from my component that causes the crash.
Character = new JPH::CharacterVirtual ( &Settings, JoltHelpers::ToJoltPos(GetUpdatedComponentTransform().GetLocation()), JoltHelpers::ToJoltRot(GetUpdatedComponentTransform().GetRotation()), 0, Subsystem->GetMainPhysicsSystem() );

This is following the way it's done in the CharacterVirtual/CharacterBase Test classes

[GreggoryAddison-AntiHeroGameStudio]

So I've just done a simple test and it seems that you need to allocate memory per class that will create Jolt classes. I'm not sure if this is the right approach but I was able to avoid the crash that was happening.

[jrouwe]

Most likely you just forgot to call RegisterDefaultAllocator so that the Allocate function is a nullptr. If you then new a Jolt class you'll instantly crash while trying to call that nullptr.

[GreggoryAddison-AntiHeroGameStudio]

I had a feeling it was that when I read another post with a similar issue to mine. I have a singleton class that does call RegisterDefaultAllocator My issue was I was allocating from a class that didn't. My question now is, do you recommend using a single class to handle all creation/destruction of jolt classes? Also what are the ramifications of calling RegisterDefaultAllocator in multiple classes? I was able to get my code to function properly by calling RegisterDefaultAllocator for the second time in this separate class. I don't think its a good practice but I wanted to know for sure.

[jrouwe]

I would call this function as early as possible in your main function, but if that's not possible it's not a problem to call it multiple times.

Since you don't seem to want a custom memory allocator anyway, you can also recompile Jolt with JPH_DISABLE_CUSTOM_ALLOCATOR defined to remove the need to call RegisterDefaultAllocator. In this case JPH_OVERRIDE_NEW_DELETE defines to nothing.

See:

JoltPhysics/Jolt/Core/Memory.h

Lines 70 to 81 in 65f5c16

	// Directly define the allocation functions
	JPH_EXPORT void *Allocate(size_t inSize);
	JPH_EXPORT void *Reallocate(void *inBlock, size_t inOldSize, size_t inNewSize);
	JPH_EXPORT void Free(void *inBlock);
	JPH_EXPORT void *AlignedAllocate(size_t inSize, size_t inAlignment);
	JPH_EXPORT void AlignedFree(void *inBlock);
	// Don't implement allocator registering
	inline void RegisterDefaultAllocator() { }
	// Don't override new/delete
	#define JPH_OVERRIDE_NEW_DELETE

[GreggoryAddison-AntiHeroGameStudio]

Thanks, I appreciate it!