failOnError broken

[delanym]

This configuration will fail the build if a relocation is found:

      <plugin>
        <groupId>biz.lermitage.oga</groupId>
        <artifactId>oga-maven-plugin</artifactId>
        <version>1.8.0</version>
        <executions>
          <execution>
            <id>default-cli</id>
            <goals>
              <goal>check</goal>
            </goals>
            <phase>validate</phase>
            <configuration>
              <failOnError>false</failOnError>
              <skip>false</skip>
            </configuration>
          </execution>
        </executions>
      </plugin>

[jonathanlermitage]

@delanym Can you please share a sample project? I applied this config to https://github.com/jonathanlermitage/manon (it has 1 relocation), but it doesn't fail the build.

[delanym]

@jonathanlermitage sorry I see it did succeed. The log level is set to ERROR. Can this rather be WARNING, or be a configurable log level like in ossindex-maven-enforcer-rules?

I guess Im taking issue with the whole opinionated view of this plugin that a relocation represents a deprecation and a problem. Using an older groupId is not necessarily a problem, particularly when we are constrained to a version that was only published under the older groupId. Would you be open to an PR that changes instances of "should be replaced by" to "was relocated to" etc?

[jonathanlermitage]

@delanym No problem 😁

Set the log level to warning or make it configurable, and replace "should be replaced by" to "was relocated to"
-> I totally agree, thx!