Skip to content

Commit 24b2c42

Browse files
author
jan
committed
Bugs solved: export as insert statement damages date values
Under Java 11 and macos: SQLRunner does not start.
1 parent 94e768f commit 24b2c42

File tree

8 files changed

+18
-14
lines changed

8 files changed

+18
-14
lines changed

.DS_Store

8 KB
Binary file not shown.

build.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@
198198
version="${version}"
199199
mainclass="${mainclass}"
200200
jvmversion="1.8+"
201-
vmoptions="-Xmx8G -Dcom.sun.management.jmxremote=true -Dapple.awt.graphics.UseQuartz=true">
201+
vmoptions="-Xmx4G -Dcom.sun.management.jmxremote=true -Dapple.awt.graphics.UseQuartz=true">
202202
<jarfileset dir="${lib}">
203203
<include name="*.jar" />
204204
<exclude name="ui.jar" />

src/main/java/ReleaseNotes.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ http://jan-lolling.de/#sqlrunner
55

66
release notes
77
-------------
8+
Version 20.7
9+
- Export result-set data bug fixed: insert statement use always the first timestamp value instead of column specific value
10+
811
Version 20.6
912
- Model: Filter works now again
1013
Version 20.5

src/main/java/VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20.6
1+
20.7

src/main/java/sqlrunner/Database.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2203,34 +2203,35 @@ private String createInsertLine(
22032203
final StringBuilder sb = new StringBuilder();
22042204
sb.append(insertStart); // jetzt ist alles fertig bis zu values ( ...
22052205
for (int c = 0; c < getColumnCount(); c++) {
2206+
Object value = getValueAt(row, c);
22062207
if (getColumnBasicType(c) == BasicDataType.DATE.getId()) {
2207-
if (getValueAt(row, c) != null) {
2208-
final String s = sdf.format((java.util.Date) getValueAt(row,
2209-
c));
2208+
if (value != null) {
2209+
final String s = sdf.format((java.util.Date) value);
22102210
final int p0 = dateFormatTemplate.indexOf("<");
2211+
String dateStrValue = "";
22112212
if (p0 != -1) {
22122213
final int p1 = dateFormatTemplate.indexOf(">", p0 + 1);
2213-
dateFormatTemplate = dateFormatTemplate.substring(0, p0)
2214+
dateStrValue = dateFormatTemplate.substring(0, p0)
22142215
+ s
22152216
+ dateFormatTemplate.substring(p1 + 1,
22162217
dateFormatTemplate.length());
22172218
}
22182219
// dateFormatTemplate ist nun kein Template mehr
2219-
sb.append(dateFormatTemplate);
2220+
sb.append(dateStrValue);
22202221
} else {
22212222
sb.append("null");
22222223
}
22232224
} else if (BasicDataType.isStringType(getColumnBasicType(c))) {
22242225
sb.append('\'');
2225-
if (getValueAt(row, c) != null) {
2226-
sb.append(dublicateSingleQuotas(getValueAt(row, c).toString()
2226+
if (value != null) {
2227+
sb.append(dublicateSingleQuotas(value.toString()
22272228
.replace('\n', ' ')
22282229
.replace('\r', ' ')));
22292230
}
22302231
sb.append('\'');
22312232
} else {
2232-
if (getValueAt(row, c) != null) {
2233-
sb.append(getValueAt(row, c).toString()
2233+
if (value != null) {
2234+
sb.append(value.toString()
22342235
.replace('\n', ' ')
22352236
.replace('\r', ' '));
22362237
} else {

src/main/java/sqlrunner/Main.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1371,7 +1371,7 @@ private static void setupMacOSXApplicationListener() {
13711371
try {
13721372
MacOSXAdapterInterface adapter = (MacOSXAdapterInterface) Class.forName("sqlrunner.MacOSXAdapter").newInstance();
13731373
adapter.setup();
1374-
} catch (Exception e) {
1374+
} catch (Throwable e) {
13751375
logger.error("Instantiation of MacOS X adapter failed: " + e.getMessage(), e);
13761376
}
13771377
}

src/main/java/sqlrunner/resources/ApplicationIcons.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* This class is generated by the IconCodeGenerator
88
*
99
* author: jan
10-
* created at: Thu Feb 06 18:34:34 CET 2020
10+
* created at: Wed Jan 06 18:01:21 CET 2021
1111
*/
1212
public class ApplicationIcons {
1313

src/main/java/sqlrunner/resources/images/ApplicationImages.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* This class is generated by the IconCodeGenerator
99
*
1010
* author: jan
11-
* created at: Thu Feb 06 18:34:34 CET 2020
11+
* created at: Wed Jan 06 18:01:21 CET 2021
1212
*/
1313
public class ApplicationImages {
1414

0 commit comments

Comments
 (0)