fix #557: use itext instead of pdfbox when remove password

Author: jiangxincode

pom.xml

@@ -12,13 +12,13 @@
         <sonar.host.url>https://sonarcloud.io</sonar.host.url>
         <pdf.version>3.0.5</pdf.version>
         <poi.version>5.4.1</poi.version>
+        <itext.version>9.2.0</itext.version>
         <log4j.version>2.25.1</log4j.version>
         <junit.minor.version>13.3</junit.minor.version>
         <junit.jupiter.version>5.${junit.minor.version}</junit.jupiter.version>
         <junit.platform.version>1.${junit.minor.version}</junit.platform.version>
         <surefire.version>3.5.3</surefire.version>
         <protobuf.version>4.32.0</protobuf.version>
-        <pdf.version>3.0.5</pdf.version>
     </properties>
     <dependencies>
         <dependency>
@@ -81,6 +81,16 @@
             <artifactId>poi-scratchpad</artifactId>
             <version>${poi.version}</version>
         </dependency>
+        <dependency>
+            <groupId>com.itextpdf</groupId>
+            <artifactId>kernel</artifactId>
+            <version>${itext.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>com.itextpdf</groupId>
+            <artifactId>bouncy-castle-adapter</artifactId>
+            <version>${itext.version}</version>
+        </dependency>
         <dependency>
             <groupId>org.bouncycastle</groupId>
             <artifactId>bcprov-jdk18on</artifactId>
@@ -161,16 +171,6 @@
             <artifactId>flatlaf</artifactId>
             <version>3.6.1</version>
         </dependency>
-        <dependency>
-            <groupId>org.apache.pdfbox</groupId>
-            <artifactId>pdfbox</artifactId>
-            <version>${pdf.version}</version>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.pdfbox</groupId>
-            <artifactId>pdfbox-io</artifactId>
-            <version>${pdf.version}</version>
-        </dependency>
         <dependency>
             <groupId>org.junit.jupiter</groupId>
             <artifactId>junit-jupiter-api</artifactId>

src/main/java/edu/jiangxin/apktoolbox/pdf/PdfUtils.java

@@ -1,5 +1,6 @@
 package edu.jiangxin.apktoolbox.pdf;
 
+import com.itextpdf.kernel.pdf.*;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 import org.apache.pdfbox.Loader;
@@ -118,4 +119,22 @@ public static void removePassword(File encryptedFile, File targetDir) {
             LOGGER.error("Error processing PDF file: {}", e.getMessage());
         }
     }
+
+    public static void removePasswordWithIText(File encryptedFile, File targetDir) {
+        PdfReader reader;
+        try {
+            reader = new PdfReader(encryptedFile).setUnethicalReading(true);
+        } catch (IOException e) {
+            LOGGER.error("Error reading PDF file: {}", e.getMessage());
+            return;
+        }
+        String targetFilePath = targetDir.getAbsolutePath() + File.separator + encryptedFile.getName();
+
+        try (PdfDocument pdfDoc = new PdfDocument(reader,
+                new PdfWriter(targetFilePath))) {
+            LOGGER.info("Remove password success: {}", targetFilePath);
+        } catch (IOException e) {
+            LOGGER.error("Error writing PDF file: {}", e.getMessage());
+        }
+    }
 }

src/main/java/edu/jiangxin/apktoolbox/pdf/passwordremover/PdfPasswordRemoverPanel.java

@@ -111,11 +111,9 @@ private void processFile(File encryptedFile, File targetDir) {
             if (Thread.currentThread().isInterrupted()) {
                 return;
             }
-            PdfUtils.removePassword(encryptedFile, targetDir);
-        } catch (Exception e) {
-            logger.error("Process file failed: " + encryptedFile.getAbsolutePath(), e);
+            PdfUtils.removePasswordWithIText(encryptedFile, targetDir);
         } catch (Throwable t) {
-            logger.error("Process file failed: " + encryptedFile.getAbsolutePath(), t);
+            logger.error("Process file failed: {}", encryptedFile.getAbsolutePath(), t);
         }
     }