Skip to content

Commit adfabcd

Browse files
authored
Bump Jenkins baseline from 2.249.x to 2.289.x (#180)
1 parent d2b4ed0 commit adfabcd

File tree

3 files changed

+5
-44
lines changed

3 files changed

+5
-44
lines changed

pom.xml

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ THE SOFTWARE.
4949
<properties>
5050
<revision>2.9</revision>
5151
<changelist>-SNAPSHOT</changelist>
52-
<jenkins.version>2.249.1</jenkins.version>
52+
<jenkins.version>2.289.3</jenkins.version>
5353
<gitHubRepo>jenkinsci/throttle-concurrent-builds-plugin</gitHubRepo>
5454
</properties>
5555

@@ -107,29 +107,18 @@ THE SOFTWARE.
107107
<dependencies>
108108
<dependency>
109109
<groupId>io.jenkins.tools.bom</groupId>
110-
<artifactId>bom-2.249.x</artifactId>
111-
<version>984.vb5eaac999a7e</version>
110+
<artifactId>bom-2.289.x</artifactId>
111+
<version>1500.ve4d05cd32975</version>
112112
<scope>import</scope>
113113
<type>pom</type>
114114
</dependency>
115-
<dependency>
116-
<groupId>org.fusesource.jansi</groupId>
117-
<artifactId>jansi</artifactId>
118-
<version>1.18</version>
119-
</dependency>
120115
</dependencies>
121116
</dependencyManagement>
122117

123118
<dependencies>
124119
<dependency>
125120
<groupId>org.jenkins-ci.plugins</groupId>
126121
<artifactId>matrix-project</artifactId>
127-
<exclusions>
128-
<exclusion>
129-
<groupId>javax.annotation</groupId>
130-
<artifactId>javax.annotation-api</artifactId>
131-
</exclusion>
132-
</exclusions>
133122
</dependency>
134123
<dependency>
135124
<groupId>org.jenkins-ci.plugins.workflow</groupId>

src/test/java/hudson/plugins/throttleconcurrents/ThrottleJobPropertyTest.java

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@
1919
import hudson.security.ACL;
2020
import hudson.security.AuthorizationStrategy;
2121
import hudson.util.CopyOnWriteMap;
22-
import hudson.util.VersionNumber;
23-
24-
import jenkins.model.Jenkins;
2522

2623
import org.junit.Rule;
2724
import org.junit.Test;
@@ -460,18 +457,7 @@ public void clearConfiguredCategories() throws Exception {
460457
HtmlPage page = webClient.goTo("configure");
461458
WebClientUtil.waitForJSExec(page.getWebClient());
462459
HtmlForm config = page.getFormByName("config");
463-
List<HtmlButton> deleteButtons;
464-
// TODO Delete the tables code once the baseline is past 2.264.
465-
VersionNumber version = Jenkins.getVersion();
466-
if (version.isNewerThanOrEqualTo(new VersionNumber("2.264"))) {
467-
deleteButtons = config.getByXPath(
468-
"//div[text()='Multi-Project Throttle Categories']/../div//button[@title='Delete']");
469-
} else {
470-
deleteButtons =
471-
config.getByXPath(
472-
"//td[@class='setting-name' and text()='Multi-Project Throttle"
473-
+ " Categories']/../td[@class='setting-main']//button[text()='Delete']");
474-
}
460+
List<HtmlButton> deleteButtons = config.getByXPath("//div[text()='Multi-Project Throttle Categories']/../div//button[@title='Delete']");
475461
assertEquals(1, deleteButtons.size());
476462
deleteButtons.get(0).click();
477463
WebClientUtil.waitForJSExec(page.getWebClient());

src/test/java/hudson/plugins/throttleconcurrents/ThrottleQueueTaskDispatcherTest.java

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import java.util.concurrent.ExecutionException;
4040
import java.util.concurrent.TimeUnit;
4141
import jenkins.model.Jenkins;
42-
import org.junit.Before;
4342
import org.junit.Rule;
4443
import org.junit.Test;
4544
import org.jvnet.hudson.test.JenkinsRule;
@@ -61,9 +60,7 @@ public class ThrottleQueueTaskDispatcherTest {
6160
private static final String maxTrace = "=> maxConcurrentPerNode' = ";
6261
private static final String mismatch = "mismatch";
6362
private static final String mismatchTrace = "node labels mismatch";
64-
private static String parentXPath;
65-
private static final String parentXPathTables = "//td[contains(text(),'Throttl')]/..";
66-
private static final String parentXPathDivs = "//div[contains(text(),'Throttl')]/..";
63+
private static final String parentXPath = "//div[contains(text(),'Throttl')]/..";
6764
private static final String saveButtonText = "Save";
6865
private static final String testCategoryName = "cat1";
6966
private static final String testCategoryLabel = testCategoryName+"label";
@@ -82,17 +79,6 @@ public class ThrottleQueueTaskDispatcherTest {
8279
@Rule
8380
public JenkinsRule r = new JenkinsRule();
8481

85-
@Before
86-
public void setUp() {
87-
// TODO Delete the tables code once the baseline is past 2.264.
88-
VersionNumber version = Jenkins.getVersion();
89-
if (version.isNewerThanOrEqualTo(new VersionNumber("2.264"))) {
90-
parentXPath = parentXPathDivs;
91-
} else {
92-
parentXPath = parentXPathTables;
93-
}
94-
}
95-
9682
/**
9783
* @throws ExecutionException upon Jenkins project build scheduling issue.
9884
* @throws InterruptedException upon Jenkins global configuration issue.

0 commit comments

Comments
 (0)