Migrate tests to JUnit5 (#84)

* Migrate annotations and imports
* Migrate assertions
* Remove public visibility for test classes and methods
* Minor code cleanup

Author: strangelookingnerd

src/test/java/hudson/plugins/robot/RobotParserTest.java

@@ -1,212 +1,212 @@
 package hudson.plugins.robot;
 
-import java.io.File;
+import org.junit.jupiter.api.Test;
 
-import org.junit.Test;
+import java.io.File;
 
-public class RobotParserTest {
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 
-    public void parse(String dir, String mask) {
-        try {
-            File directory = new File(RobotParserTest.class.getResource(dir).toURI());
-            RobotParser.RobotParserCallable remoteOperation = new RobotParser.RobotParserCallable(mask, null, null);
-            remoteOperation.invoke(directory, null);
-        } catch (Exception e) {
-            e.printStackTrace();
-            assert (false);
-        }
-    }
+class RobotParserTest {
 
     @Test
-    public void testBasic1() {
+    void testBasic1() {
         final String dir = ".";
         final String mask = "low_failure_output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic2() {
+    void testBasic2() {
         final String dir = ".";
         final String mask = "rebot_output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic3() {
+    void testBasic3() {
         final String dir = "blueocean";
         final String mask = "output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic4() {
+    void testBasic4() {
         final String dir = "graph";
         final String mask = "output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic5() {
+    void testBasic5() {
         final String dir = "model";
         final String mask = "collisions.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic6() {
+    void testBasic6() {
         final String dir = "model";
         final String mask = "new_critical_output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic7() {
+    void testBasic7() {
         final String dir = "model";
         final String mask = "output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic8() {
+    void testBasic8() {
         final String dir = "model";
         final String mask = "suite-setup-and-teardown.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic9() {
+    void testBasic9() {
         final String dir = "model";
         final String mask = "testfile.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic10() {
+    void testBasic10() {
         final String dir = "model";
         final String mask = "teardown_fail.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic11() {
+    void testBasic11() {
         final String dir = "model";
         final String mask = "testfile-001.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic12() {
+    void testBasic12() {
         final String dir = "model";
         final String mask = "testfile-002.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic13() {
+    void testBasic13() {
         final String dir = "RobotPublisherSystemTest/jobs/robot/workspace";
         final String mask = "output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic14() {
+    void testBasic14() {
         final String dir = "RobotPublisherSystemTest/jobs/collisions/workspace";
         final String mask = "output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic15() {
+    void testBasic15() {
         final String dir = "RobotPublisherSystemTest/jobs/disable-archive-output-xml/workspace";
         final String mask = "output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic16() {
+    void testBasic16() {
         final String dir = "RobotPublisherSystemTest/jobs/dont-copy/workspace";
         final String mask = "output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic17() {
+    void testBasic17() {
         final String dir = "RobotPublisherSystemTest/jobs/failingtests/workspace";
         final String mask = "output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic18() {
+    void testBasic18() {
         final String dir = "RobotPublisherSystemTest/jobs/robot29output/workspace";
         final String mask = "output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testBasic19() {
+    void testBasic19() {
         final String dir = "RobotPublisherSystemTest/jobs/oldrobotbuild/workspace";
         final String mask = "output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testNested1() {
+    void testNested1() {
         final String dir = ".";
         final String mask = "nested_output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testNested2() {
+    void testNested2() {
         final String dir = ".";
         final String mask = "nested_output2.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testRobot4() {
+    void testRobot4() {
         final String dir = ".";
         final String mask = "robot4_output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testRobot4Nested() {
+    void testRobot4Nested() {
         final String dir = ".";
         final String mask = "robot4_nested_output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testRobot4If() {
+    void testRobot4If() {
         final String dir = ".";
         final String mask = "robot4_if_output.xml";
         parse(dir, mask);
     }
 
-    /** Robot Framework 5.0 introduced TRY-EXCEPT, WHILE,
-     *  BREAK, and CONTINUE. The output file contains simple
-     *  test cases which use new features.
+    /**
+     * Robot Framework 5.0 introduced TRY-EXCEPT, WHILE,
+     * BREAK, and CONTINUE. The output file contains simple
+     * test cases which use new features.
      */
     @Test
-    public void testRobot5TryExceptFinallyWhileContinue() {
+    void testRobot5TryExceptFinallyWhileContinue() {
         final String dir = "robot5";
         final String mask = "basic_new_features_output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testEmptyArgTags() {
+    void testEmptyArgTags() {
         final String dir = ".";
         final String mask = "empty_args-output.xml";
         parse(dir, mask);
     }
 
     @Test
-    public void testRF7InlineVar() {
+    void testRF7InlineVar() {
         final String dir = "robot7";
         final String mask = "inline_var_output.xml";
         parse(dir, mask);
     }
+
+    private void parse(String dir, String mask) {
+        assertDoesNotThrow(() -> {
+            File directory = new File(RobotParserTest.class.getResource(dir).toURI());
+            RobotParser.RobotParserCallable remoteOperation = new RobotParser.RobotParserCallable(mask, null, null);
+            remoteOperation.invoke(directory, null);
+        });
+    }
 }