Skip to content

Commit 6003f45

Browse files
authored
Make widget title clickable (#1006)
1 parent fb46a0e commit 6003f45

File tree

4 files changed

+53
-13
lines changed

4 files changed

+53
-13
lines changed

src/main/frontend/pipeline-console-view/pipeline-console/main/components/stages.scss

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,25 @@
5353
line-height: 2rem;
5454
font-weight: var(--font-bold-weight);
5555
font-size: var(--font-size-sm);
56+
gap: 0.375rem;
57+
color: var(--text-color-secondary);
58+
text-decoration: none !important;
59+
60+
&[href] {
61+
color: var(--text-color) !important;
62+
}
63+
64+
svg {
65+
width: 0.875rem;
66+
height: 0.875rem;
67+
color: var(--text-color-secondary);
68+
transition: color var(--standard-transition);
69+
margin-right: -0.25rem;
70+
}
71+
72+
&:hover svg {
73+
color: var(--text-color);
74+
}
5675
}
5776
}
5877

@@ -68,11 +87,10 @@
6887

6988
.pgv-stages-graph__controls {
7089
position: absolute;
71-
inset: 0.1rem;
90+
inset: 0.1875rem;
7291
display: flex;
7392
z-index: 1;
7493
backdrop-filter: blur(10px);
75-
background: red;
7694
border-radius: 0.45rem;
7795
align-items: center;
7896
color: var(--text-color-secondary);

src/main/frontend/pipeline-console-view/pipeline-console/main/components/stages.tsx

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ export default function Stages({
1919
selectedStage,
2020
stageViewPosition,
2121
onStageSelect,
22+
onRunPage,
2223
}: StagesProps) {
2324
const [isExpanded, setIsExpanded] = useState(false);
2425

@@ -29,9 +30,29 @@ export default function Stages({
2930
"pgv-stages-graph--dialog": isExpanded,
3031
})}
3132
>
32-
<div className={"pgv-stages-graph__controls pgv-stages-graph__heading"}>
33-
Graph
34-
</div>
33+
{!onRunPage && (
34+
<div className={"pgv-stages-graph__controls pgv-stages-graph__heading"}>
35+
Graph
36+
</div>
37+
)}
38+
{onRunPage && (
39+
<a
40+
className={"pgv-stages-graph__controls pgv-stages-graph__heading"}
41+
href="pipeline-overview"
42+
>
43+
Stages
44+
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
45+
<path
46+
fill="none"
47+
stroke="currentColor"
48+
strokeLinecap="round"
49+
strokeLinejoin="round"
50+
strokeWidth="48"
51+
d="M184 112l144 144-144 144"
52+
/>
53+
</svg>
54+
</a>
55+
)}
3556
<div className={"pgv-stages-graph__controls pgw-fullscreen-controls"}>
3657
<Tooltip content={isExpanded ? "Close" : "Expand"}>
3758
<button
@@ -98,6 +119,7 @@ interface StagesProps {
98119
selectedStage?: StageInfo;
99120
stageViewPosition: StageViewPosition;
100121
onStageSelect?: (nodeId: string) => void;
122+
onRunPage?: boolean;
101123
}
102124

103125
function ZoomControls() {

src/main/frontend/pipeline-graph-view/app.scss

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,14 @@
2323
svg {
2424
width: 1rem;
2525
height: 1rem;
26+
transition: color var(--standard-transition);
2627
}
2728

2829
&:not(:disabled) {
29-
&:hover {
30-
svg {
31-
opacity: 0.75;
32-
}
33-
}
34-
30+
&:hover,
3531
&:active {
3632
svg {
37-
opacity: 0.5;
33+
color: var(--text-color);
3834
}
3935
}
4036
}

src/main/frontend/pipeline-graph-view/app.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,11 @@ export default function App() {
1818
return (
1919
<div>
2020
<UserPreferencesProvider>
21-
<Stages stages={run.stages} stageViewPosition={StageViewPosition.TOP} />
21+
<Stages
22+
stages={run.stages}
23+
stageViewPosition={StageViewPosition.TOP}
24+
onRunPage
25+
/>
2226
</UserPreferencesProvider>
2327
</div>
2428
);

0 commit comments

Comments
 (0)