Skip to content

Commit 1065330

Browse files
authored
Fix step header and stage tree not sticking pre header redesign (#832)
1 parent f1ae3d2 commit 1065330

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

src/main/frontend/pipeline-console-view/pipeline-console/main/components/stages.scss

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,17 @@
1414
&--left {
1515
--additional-height: 0px;
1616
position: sticky;
17-
top: calc(var(--header-height) + var(--section-padding));
17+
top: calc(var(--pgv-header-height) + var(--section-padding));
1818
height: calc(
1919
(100vh + var(--additional-height)) -
20-
(var(--header-height) + 100px + var(--section-padding))
20+
(var(--pgv-header-height) + 100px + var(--section-padding))
2121
);
2222
max-height: calc(
2323
100vh -
24-
(var(--header-height) + var(--section-padding) + var(--section-padding))
24+
(
25+
var(--pgv-header-height) + var(--section-padding) +
26+
var(--section-padding)
27+
)
2528
);
2629
}
2730

src/main/frontend/pipeline-console-view/pipeline-console/main/console-log-card.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
.pgv-step-detail-header {
1111
position: sticky;
12-
top: calc(var(--header-height) + 0.375rem);
12+
top: calc(var(--pgv-header-height) + 0.375rem);
1313
z-index: 1;
1414
display: grid;
1515
grid-template-columns: 1fr auto;
@@ -101,7 +101,7 @@
101101

102102
.pgv-show-more-logs {
103103
position: sticky;
104-
top: calc(var(--header-height) + 0.375rem + 0.375rem + 2.375rem);
104+
top: calc(var(--pgv-header-height) + 0.375rem + 0.375rem + 2.375rem);
105105
background: var(--card-background);
106106
box-shadow: 0 0 0.375rem var(--card-background);
107107
z-index: 10;

src/main/frontend/pipeline-console-view/pipeline-console/main/pipeline-console.scss

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
:root {
2+
// can be removed and `--header-height` used directly when jenkins baseline is 2.507
3+
--pgv-header-height: var(--header-height, 45.5938px);
4+
}
5+
16
.ansi-fg-0 {
27
color: var(--black, #333);
38
}
@@ -65,7 +70,7 @@
6570

6671
.pgv-sticky-sidebar {
6772
position: sticky;
68-
top: calc(var(--header-height) + var(--section-padding));
73+
top: calc(var(--pgv-header-height) + var(--section-padding));
6974
}
7075

7176
.pgv-skeleton-column {

0 commit comments

Comments
 (0)