Merge pull request #740 from jenkinsci/revert-738-contributeTestData

Revert "Do not call `contributeTestData` with `WorkflowRun` lock held"

Author: jglick

src/main/java/hudson/tasks/junit/JUnitResultArchiver.java

@@ -291,15 +291,6 @@ public static TestResultSummary parseAndSummarize(
                             task.isKeepTestNames())
                     .summarizeResult(testResults, build, pipelineTestDetails, workspace, launcher, listener, storage);
         }
-        var data = new ArrayList<TestResultAction.Data>();
-        if (task.getTestDataPublishers() != null) {
-            for (var tdp : task.getTestDataPublishers()) {
-                var d = tdp.contributeTestData(build, workspace, launcher, listener, result);
-                if (d != null) {
-                    data.add(d);
-                }
-            }
-        }
 
         synchronized (build) {
             // TODO can the build argument be omitted now, or is it used prior to the call to addAction?
@@ -329,7 +320,14 @@ public static TestResultSummary parseAndSummarize(
                 }
             }
 
-            data.forEach(action::addData);
+            if (task.getTestDataPublishers() != null) {
+                for (TestDataPublisher tdp : task.getTestDataPublishers()) {
+                    TestResultAction.Data d = tdp.contributeTestData(build, workspace, launcher, listener, result);
+                    if (d != null) {
+                        action.addData(d);
+                    }
+                }
+            }
 
             if (appending) {
                 build.save();