Skip to content

Commit 5c28483

Browse files
Jagrutititimja
andauthored
[JENKINS-69658] Move internal script block in "failed-test.jelly" to external file (#439)
Co-authored-by: Tim Jacomb <[email protected]>
1 parent 085131f commit 5c28483

File tree

2 files changed

+21
-22
lines changed

2 files changed

+21
-22
lines changed

src/main/resources/lib/hudson/test/failed-test.jelly

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -35,28 +35,7 @@ THE SOFTWARE.
3535
</st:attribute>
3636
</st:documentation>
3737
<st:once>
38-
<script type="text/javascript">
39-
<!-- TODO make sure load doesn't happen every time -->
40-
function showFailureSummary(id,query) {
41-
var element = document.getElementById(id)
42-
element.style.display = "";
43-
document.getElementById(id + "-showlink").style.display = "none";
44-
document.getElementById(id + "-hidelink").style.display = "";
45-
46-
if (typeof query !== 'undefined') {
47-
var rqo = new XMLHttpRequest();
48-
rqo.open('GET', query, true);
49-
rqo.onreadystatechange = function() { element.innerHTML = rqo.responseText; }
50-
rqo.send(null);
51-
}
52-
}
53-
54-
function hideFailureSummary(id) {
55-
document.getElementById(id).style.display = "none";
56-
document.getElementById(id + "-showlink").style.display = "";
57-
document.getElementById(id + "-hidelink").style.display = "none";
58-
}
59-
</script>
38+
<st:adjunct includes="lib.hudson.test.js.failureSummary" />
6039
<style type="text/css">
6140
.failure-summary {
6241
margin-left: 2em;
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
2+
function showFailureSummary(id,query) {
3+
var element = document.getElementById(id)
4+
element.style.display = "";
5+
document.getElementById(id + "-showlink").style.display = "none";
6+
document.getElementById(id + "-hidelink").style.display = "";
7+
8+
if (typeof query !== 'undefined') {
9+
var rqo = new XMLHttpRequest();
10+
rqo.open('GET', query, true);
11+
rqo.onreadystatechange = function() { element.innerHTML = rqo.responseText; }
12+
rqo.send(null);
13+
}
14+
}
15+
16+
function hideFailureSummary(id) {
17+
document.getElementById(id).style.display = "none";
18+
document.getElementById(id + "-showlink").style.display = "";
19+
document.getElementById(id + "-hidelink").style.display = "none";
20+
}

0 commit comments

Comments
 (0)