New plugin hosting request: daocloud-oic-auth

[yyzxw]

Repository URL

https://github.com/amamba-io/daocloud-oic-auth-plugin

New Repository Name

daocloud-oic-auth-plugin

Description

This plugin provides Jenkins integration with the DCE5 (Daocloud Enterprice 5th) platform. It provides user authentication login based on OIDC protocol and the ability to use the DCE5 platform for permission verification

GitHub users to have commit permission

@amamba

Jenkins project users to have release permission

@amamba

Issue tracker

GitHub issues

[jenkins-cert-app]

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

• /audit-ok => the audit is complete, the hosting can continue 🎉.
• /audit-skip => the audit is not necessary, the hosting can continue 🎉.
• /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

• /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
• /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.34.6)

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: You must add a 'groupId' in your pom.xml with the value io.jenkins.plugins.
• ⛔ Required: The pom.xml file in the root of the origin repository is not valid
• ⛔ Required: The parent pom version '5.18' should be at least '5.24' or higher.
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @amamba (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @amamba (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following issues have been identified related to plugin dependency management:
  ** The bom version 4228.v0a_71308d905b_ of bom-${jenkins.baseline}.x should be updated to the latest version 5054.v620b_5d2b_d5e6
• ⛔ Required: The file .github/CODEOWNERS doesn't contain the expected line * @jenkinsci/daocloud-oic-auth-plugin-developers
• ⛔ Required: The dependency org.apache.httpcomponents:httpclient should be replaced with a dependency to the api plugin org.jenkins-ci.plugins:apache-httpcomponents-client-4-api
• ⛔ Required: Please remove the developers tag from your pom.xml. This information is fetched from this repository on the update site.
• ⛔ Required: Please define the property hpi.strictBundledArtifacts and set it to true. This should help prevent accidental library bundling when adding and updating dependencies.See Bundling third-party libraries.
• ⛔ Required: No files found related to automatically updating the plugin dependencies. Please ensure that you have dependabot, renovate or updatecli configured in the repo. A suitable version for dependabot can be downloaded here
• ⛔ Required: Missing file .github/workflows/jenkins-security-scan.yml. This file helps to keep your plugin conform to security standards defined by the Jenkins project. A suitable version can be downloaded here

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[jenkins-cert-app]

The Jenkins Security Scan discovered 17 finding(s) 🔍.

For every identified issue, please do one of the following:

• Implement the recommended fix to address the issue.
• If you think it's a false positive, suppress the warning directly within the code.
• Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

• If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
• If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

---

Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

OicSecurityRealm.java#1441

Potential CSRF vulnerability: If OicSecurityRealm#doFinishLogin connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

OicSecurityRealm.java#1309

Potential CSRF vulnerability: If OicSecurityRealm#doLogout connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

OicSecurityRealm.java#1068

Potential CSRF vulnerability: If OicSecurityRealm#doCommenceLogin connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

Stapler: Missing permission check

You can find detailed information about this finding here.

LoginQueryParameter.java#24

Potential missing permission check in DescriptorImpl#doCheckKey

LogoutQueryParameter.java#23

Potential missing permission check in DescriptorImpl#doCheckKey

OicSecurityRealm.java#1794

Potential missing permission check in DescriptorImpl#doCheckDisableTokenVerification

OicSecurityRealm.java#1786

Potential missing permission check in DescriptorImpl#doCheckDisableSslVerification

OicSecurityRealm.java#1441

Potential missing permission check in OicSecurityRealm#doFinishLogin

OicSecurityRealm.java#1309

Potential missing permission check in OicSecurityRealm#doLogout

OicSecurityRealm.java#1068

Potential missing permission check in OicSecurityRealm#doCommenceLogin

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

AbstractKeyValueDescribable.java#15

Field should be reviewed whether it stores a password and is serialized to disk: key

JwtUtils.java#74

Field should be reviewed whether it stores a password and is serialized to disk: token

OicSecurityRealm.java#227

Field should be reviewed whether it stores a password and is serialized to disk: tokenFieldToCheckValue

OicSecurityRealm.java#225

Field should be reviewed whether it stores a password and is serialized to disk: tokenFieldToCheckKey

OicServerManualConfiguration.java#42

Field should be reviewed whether it stores a password and is serialized to disk: tokenServerUrl

Jenkins: Generally unsafe method calls

You can find detailed information about this finding here.

ProxyAwareResourceRetriever.java#52

Potentially unsafe invocation of HttpsURLConnection#setHostnameVerifier

TLSUtils.java#19

Potentially unsafe invocation of SSLContext#init

[yyzxw]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @amamba (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @amamba (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[yyzxw]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @amamba (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @amamba (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[yyzxw]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @amamba (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @amamba (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[yyzxw]

/request-security-scan