Check if Windows implementation is correct

[jakewilliami]

Despite finding resources to calculate the Windows implementation of is_hidden, I have found resources that may indicate we do not need to check for the existence of FILE_ATTRIBUTE_SYSTEM in the file's attributes.^{[1], [2]} We should investigate this to make sure the way we do it is correct.

[jakewilliami]

Um...GetFileAttributesA!=GetFileAttributesW?

EDIT: Oh, I think it's okay:

GetFileAttributesA:

DWORD GetFileAttributesA(
  [in] LPCSTR lpFileName
);

GetFileAttributesW:

DWORD GetFileAttributesW(
  [in] LPCWSTR lpFileName
);

So they take different input types.

LPCSTR

An LPCSTR is a 32-bit pointer to a constant null-terminated string of 8-bit Windows (ANSI) characters.

LPCWSTR

An LPCWSTR is a 32-bit pointer to a constant string of 16-bit Unicode characters, which MAY be null-terminated.

So probably in the interest of non-ANSI path names we should use GetFileAttributesW, despite possible performance considerations.

[jakewilliami]

I'm really not sure we do need to check for FILE_ATTRIBUTE_SYSTEM. The description of the flag is

A file or directory that the operating system uses a part of, or uses exclusively.

Surely that doesn't make it hidden? I need to test on a Windows machine by viewing it in explorer.exe or by using dir to see if it's displayed.

[jakewilliami]

Regarding the above (#11 (comment)), I've asked a question on this thread.

[jakewilliami]

See this implementation for inspiration.