refactor: centralize cache TTL constants for Cloudflare IPs and RDAP bootstrap data

Author: jakejarvis

lib/cloudflare.ts

@@ -3,7 +3,10 @@ import "server-only";
 import * as ipaddr from "ipaddr.js";
 import { cache } from "react";
 import { acquireLockOrWaitForResult } from "@/lib/cache";
-import { CLOUDFLARE_IPS_URL } from "@/lib/constants";
+import {
+  CLOUDFLARE_IPS_CACHE_TTL_SECONDS,
+  CLOUDFLARE_IPS_URL,
+} from "@/lib/constants";
 import { ipV4InCidr, ipV6InCidr } from "@/lib/ip";
 import { redis } from "@/lib/redis";
 
@@ -14,7 +17,6 @@ export interface CloudflareIpRanges {
 
 const CACHE_KEY = "cloudflare:ip-ranges";
 const LOCK_KEY = "cloudflare:ip-ranges:lock";
-const CACHE_TTL_SECONDS = 604800; // 1 week
 
 let lastLoadedIpv4Parsed: Array<[ipaddr.IPv4, number]> | undefined;
 let lastLoadedIpv6Parsed: Array<[ipaddr.IPv6, number]> | undefined;
@@ -101,7 +103,7 @@ const getCloudflareIpRanges = cache(async (): Promise<CloudflareIpRanges> => {
       try {
         ranges = await fetchCloudflareIpRanges();
         await redis.set(CACHE_KEY, ranges, {
-          ex: CACHE_TTL_SECONDS,
+          ex: CLOUDFLARE_IPS_CACHE_TTL_SECONDS,
         });
         parseAndCacheRanges(ranges);
         console.info("[cloudflare-ips] IP ranges fetched (not cached)");

lib/constants.ts

@@ -8,24 +8,35 @@ export const USER_AGENT =
 
 export const REPOSITORY_SLUG = "jakejarvis/domainstack.io";
 
+// Time constants (in seconds)
+const ONE_MINUTE = 60;
+const ONE_HOUR = ONE_MINUTE * 60;
+const ONE_DAY = ONE_HOUR * 24;
+const ONE_WEEK = ONE_DAY * 7;
+
 /**
  * RDAP Bootstrap Registry URL from IANA.
  * This JSON file maps TLDs to their authoritative RDAP servers.
  * @see https://datatracker.ietf.org/doc/html/rfc7484
  */
 export const RDAP_BOOTSTRAP_URL = "https://data.iana.org/rdap/dns.json";
+/**
+ * RDAP Bootstrap cache TTL in seconds.
+ * The bootstrap registry changes very infrequently, so we cache it for 1 week.
+ */
+export const RDAP_BOOTSTRAP_CACHE_TTL_SECONDS = ONE_WEEK;
 
 /**
  * Cloudflare IP Ranges URL.
  * This JSON file contains the IP ranges for Cloudflare's network.
  * @see https://developers.cloudflare.com/api/resources/ips/methods/list/
  */
 export const CLOUDFLARE_IPS_URL = "https://api.cloudflare.com/client/v4/ips";
-
-// Time constants (in seconds)
-const ONE_HOUR = 60 * 60;
-const ONE_DAY = 24 * ONE_HOUR;
-const ONE_WEEK = 7 * ONE_DAY;
+/**
+ * Cloudflare IP Ranges cache TTL in seconds.
+ * The IP ranges change infrequently, so we cache it for 1 week.
+ */
+export const CLOUDFLARE_IPS_CACHE_TTL_SECONDS = 604800; // 1 week
 
 // ===== Blob Storage Cache TTLs =====
 // How long to cache uploaded assets (favicons, screenshots, social images)

lib/rdap-bootstrap.ts

@@ -3,12 +3,14 @@ import "server-only";
 import type { BootstrapData } from "rdapper";
 import { cache } from "react";
 import { acquireLockOrWaitForResult } from "@/lib/cache";
-import { RDAP_BOOTSTRAP_URL } from "@/lib/constants";
+import {
+  RDAP_BOOTSTRAP_CACHE_TTL_SECONDS,
+  RDAP_BOOTSTRAP_URL,
+} from "@/lib/constants";
 import { redis } from "@/lib/redis";
 
 const CACHE_KEY = "rdap:bootstrap";
 const LOCK_KEY = "rdap:bootstrap:lock";
-const CACHE_TTL_SECONDS = 604800; // 1 week (bootstrap changes very infrequently)
 
 /**
  * Fetch RDAP bootstrap data with Redis caching.
@@ -48,7 +50,7 @@ export const getRdapBootstrapData = cache(async (): Promise<BootstrapData> => {
 
         bootstrap = await res.json();
         await redis.set(CACHE_KEY, bootstrap, {
-          ex: CACHE_TTL_SECONDS,
+          ex: RDAP_BOOTSTRAP_CACHE_TTL_SECONDS,
         });
         console.info("[rdap-bootstrap] Bootstrap data fetched (not cached)");
       } catch (err) {