Skip to content

Commit 1d47c6a

Browse files
committed
PopoverRef.close will destroy popover component
1 parent b84ee29 commit 1d47c6a

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "deneb-ui",
3-
"version": "4.1.2",
3+
"version": "4.2.0",
44
"scripts": {
55
"ng": "ng",
66
"start": "ng serve --project Deneb-UI-Demo",

projects/irohalab/deneb-ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@irohalab/deneb-ui",
3-
"version": "4.1.2",
3+
"version": "4.2.0",
44
"description": "Building blocks for mira-ui",
55
"author": "Everett Summer",
66
"license": "Apache-2.0",

projects/irohalab/deneb-ui/src/popover/popover-ref.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,10 @@ export class UIPopoverRef<T> {
3232
this._appRef.attachView(componentRef.hostView);
3333
this._popper = new Popper(refElement, componentElement, {
3434
placement: this.placement
35-
// onCreate: (data) => {
36-
// console.log('onCreate', data);
37-
// },
38-
// onUpdate: (data) => {
39-
// console.log('onUpdate', data);
40-
// }
4135
});
4236
this._disposeCallback = () => {
4337
this._appRef.detachView(componentRef.hostView);
38+
componentRef.destroy();
4439
};
4540
}
4641

0 commit comments

Comments
 (0)