Switch from isDefault to isAuthoredValue

Author: chellmuth

source/MaterialXGenOslNetwork/OslNetworkShaderGenerator.cpp

@@ -65,12 +65,12 @@ ShaderPtr OslNetworkShaderGenerator::generate(const string& name, ElementPtr ele
 
             const ShaderOutput* connection = input->getConnection();
             if (!connection || connection->getNode() == &graph) {
-                if (input->isDefault())
+                if (!input->isAuthoredValue())
                     continue;
 
                 if (input->getName() == "backsurfaceshader"
                     || input->getName() == "displacementshader")
-                    continue; // FIXME: these aren't getting pruned by isDefault
+                    continue; // FIXME: these aren't getting pruned by isAuthoredValue
 
                 string value = _syntax->getValue(input);
                 if (value == "null_closure()")

source/MaterialXGenShader/ShaderNode.cpp

@@ -199,14 +199,14 @@ ShaderNodePtr ShaderNode::create(const ShaderGraph* parent, const string& name,
             if (context.getShaderGenerator().getSyntax().remapEnumeration(portValue, portType, enumNames, enumResult))
             {
                 input = newNode->addInput(port->getName(), enumResult.first);
-                input->setValue(enumResult.second, true);
+                input->setValue(enumResult.second, false);
             }
             else
             {
                 input = newNode->addInput(port->getName(), portType);
                 if (!portValue.empty())
                 {
-                    input->setValue(port->getResolvedValue(), true);
+                    input->setValue(port->getResolvedValue(), false);
                 }
             }
             if (port->getIsUniform())

source/MaterialXGenShader/ShaderNode.h

@@ -165,13 +165,17 @@ class MX_GENSHADER_API ShaderPort : public std::enable_shared_from_this<ShaderPo
     const string& getSemantic() const { return _semantic; }
 
     /// Set a value on this port.
-    void setValue(ValuePtr value, bool isDefault = false) { _value = value; _isDefault = isDefault; }
+    void setValue(ValuePtr value, bool isAuthoredValue = true)
+    {
+        _value = value;
+        _isAuthoredValue = isAuthoredValue;
+    }
 
     /// Return the value set on this port.
     ValuePtr getValue() const { return _value; }
 
-    // Is the value still its default.
-    bool isDefault() const { return _isDefault; }
+    // Has the value been overridden.
+    bool isAuthoredValue() const { return _isAuthoredValue; }
 
     /// Return the value set on this port as a string, or an empty string if there is no value.
     string getValueString() const;
@@ -259,7 +263,7 @@ class MX_GENSHADER_API ShaderPort : public std::enable_shared_from_this<ShaderPo
     string _geomprop;
     ShaderMetadataVecPtr _metadata;
     uint32_t _flags;
-    bool _isDefault{false};
+    bool _isAuthoredValue{false};
 };
 
 /// @class ShaderInput