be a tad more defensive about return value from json_decode

dannyvankooten · dannyvankooten · commit c3e1caa44098 · 2024-11-07T10:21:33.000+01:00
diff --git a/integrations/prosopo-procaptcha/class-procaptcha.php b/integrations/prosopo-procaptcha/class-procaptcha.php
@@ -219,8 +219,7 @@ protected function is_human_made_request()
 
 		$body = wp_remote_retrieve_body($response);
 		$body = json_decode($body, true);
-
-		$is_verified = $body['verified'] ?? false;
+		$is_verified = is_array($body) && isset($body['verified']) && $body['verified'];
 
 		return true === $is_verified;
 	}

Original file line number	Diff line number	Diff line change
`@@ -219,8 +219,7 @@ protected function is_human_made_request()`
`219`	`219`
`220`	`220`	`$body = wp_remote_retrieve_body($response);`
`221`	`221`	`$body = json_decode($body, true);`
`222`		`-`
`223`		`- $is_verified = $body['verified'] ?? false;`
	`222`	`+ $is_verified = is_array($body) && isset($body['verified']) && $body['verified'];`
`224`	`223`
`225`	`224`	`return true === $is_verified;`
`226`	`225`	`}`