Fixed and added missing header of ael2005_conf.c file and a comment on top of ael2005.h#2
Open
forconesi wants to merge 1 commit intohwanju:masterfrom
Open
Fixed and added missing header of ael2005_conf.c file and a comment on top of ael2005.h#2forconesi wants to merge 1 commit intohwanju:masterfrom
forconesi wants to merge 1 commit intohwanju:masterfrom
Conversation
`ael2005_conf.h' file. Physical interfaces are mapped to nf0, nf1, nf2 and nf3 interfaces in the host through its corresponding Port Address (PRTAD). PRTAD of each interface is hard-wired on the board so four variables of type `bool' are added to document and make clear which physical interface is being configured with a given PRTAD. `timeout' variable is set to zero for every loop, otherwise it expires when all the four ports are configured (and the driver fails to load). Fixed comments on the code to match the general coding style and changed two messages written by pr_info() To test it: remove the power of the board so PHYs get unconfigured. Boot the machine, load the driver and run a network application, e.g. iperf.
Author
|
This is take 2, I screwed things up in the previous pull request. I changed the branch name to avoid confusion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing header of
ael2005_conf.cfile and a comment on top ofael2005_conf.hfile.Physical interfaces are mapped to nf0, nf1, nf2 and nf3 interfaces in
the host through its corresponding Port Address (PRTAD). PRTAD of each
interface is hard-wired on the board so four variables of type
boolare added to document and make clear which physical interface is being
configured with a given PRTAD.
timeoutvariable is set to zero for every loop, otherwise it expireswhen all the four ports are configured (and the driver fails to load).
Fixed comments on the code to match the general coding style and changed
two messages written by pr_info()
To test it: remove the power of the board so PHYs get unconfigured.
Boot the machine, load the driver and run a network application, e.g.
iperf.