fix: Use return value rather than pass-by-reference

Author: ralflang

admin/alarms.php

@@ -43,7 +43,7 @@
 }
 
 if ($form->validate()) {
-    $form->getInfo($vars, $info);
+    $info = $form->getInfo($vars, $info);
     if (empty($info['alarm'])) {
         $info['alarm'] = strval(new Horde_Support_Uuid());
     }

admin/config/index.php

@@ -432,7 +432,7 @@ function _uploadFTP($params)
     $ftpform->addVariable(_("Password"), 'password', 'password', false);
 
     if ($ftpform->validate($vars)) {
-        $ftpform->getInfo($vars, $info);
+        $info = $ftpform->getInfo($vars, $info);
         $upload = _uploadFTP($info);
         if ($upload) {
             $notification->push(_("Uploaded all application configuration files to the server."), 'horde.success');

admin/user.php

@@ -57,7 +57,7 @@
 case 'add':
     $addForm->validate($vars);
     if ($addForm->isValid() && $vars->get('formname') == 'adduser') {
-        $addForm->getInfo($vars, $info);
+        $info = $addForm->getInfo($vars, $info);
 
         if (empty($info['user_name']) && isset($info['extra']['user_name'])) {
             $info['user_name'] = $info['extra']['user_name'];

services/changepassword.php

@@ -32,7 +32,7 @@
 $form->addVariable(_("Retype new password"), 'password_2', 'password', true);
 
 if ($form->validate($vars)) {
-    $form->getInfo($vars, $info);
+    $info = $form->getInfo($vars, $info);
 
     if ($registry->getAuthCredential('password') != $info['old_password']) {
         $notification->push(_("Old password is not correct."), 'horde.error');

services/resetpassword.php

@@ -61,7 +61,7 @@
 
 /* Validate the form. */
 if ($can_validate && $form->validate($vars)) {
-    $form->getInfo($vars, $info);
+    $info = $form->getInfo($vars, $info);
 
     /* Fetch values from prefs for selected user. */
     $answer = $prefs->getValue('security_answer');

signup.php

@@ -35,7 +35,7 @@
 $vars = $injector->getInstance('Horde_Variables');
 $formsignup = new Horde_Core_Auth_Signup_Form($vars);
 if ($formsignup->validate()) {
-    $formsignup->getInfo($vars, $info);
+    $info = $formsignup->getInfo($vars, $info);
     $error = $success_message = null;
 
     if ($info instanceof PEAR_Error) {